From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Thu, 21 Jan 2010 10:43:37 +0000 Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code Message-Id: <20100121.024337.57448535.davem@davemloft.net> List-Id: References: <4B574702.4040602@hp.com> <20100120.150343.236848237.davem@davemloft.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: julia@diku.dk Cc: vladislav.yasevich@hp.com, sri@us.ibm.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Julia Lawall Date: Thu, 21 Jan 2010 11:22:38 +0100 (CET) > On Wed, 20 Jan 2010, David Miller wrote: > >> From: Vlad Yasevich >> Date: Wed, 20 Jan 2010 13:10:10 -0500 >> >> > >> > >> > Julia Lawall wrote: >> >> From: Julia Lawall >> >> >> >> The variable newinet is initialized twice to the same (side effect-free) >> >> expression. Drop one initialization. >> >> >> >> A simplified version of the semantic match that finds this problem is: >> >> (http://coccinelle.lip6.fr/) >> >> >> >> // >> >> @forall@ >> >> idexpression *x; >> >> identifier f!=ERR_PTR; >> >> @@ >> >> >> >> x = f(...) >> >> ... when != x >> >> ( >> >> x = f(...,<+...x...+>,...) >> >> | >> >> * x = f(...) >> >> ) >> >> // >> >> >> >> Signed-off-by: Julia Lawall >> > >> > Acked-by: Vlad Yasevich >> >> Julia, just like patch #3 this one had the missing final >> line of the patch corrupting it, so you'll need to resubmit. > > I have generated and sent it again, but this time I don't see the problem. > If there is still a problem, perhaps you could send me back the patch you > received? You dropped Vlad' ACK in your re-submission. I'll fix it up this time, but please accumulate ACK's when resubmitting patches merely for the purpose of fixing some technical submission problem. Thanks.