From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Tue, 03 May 2016 16:47:45 +0000 Subject: Re: [PATCH 0/2] sctp: Add GSO support Message-Id: <20160503164745.GE5676@localhost.localdomain> List-Id: References: <20160502.191614.608026435064266168.davem@davemloft.net> <20160503114918.GD5676@localhost.localdomain> <20160503.120915.2184693151751282220.davem@davemloft.net> In-Reply-To: <20160503.120915.2184693151751282220.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: netdev@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, linux-sctp@vger.kernel.org, David.Laight@ACULAB.COM, alexander.duyck@gmail.com On Tue, May 03, 2016 at 12:09:15PM -0400, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Tue, 3 May 2016 08:49:18 -0300 > > > So this is just for pure tx path, no forwarding involved. > > And if that GSO segment is looped back into the stack via the > loopback interface, the packet classifier mirror action, or > netfilter? > > You cannot just GSO things and then not handle such packets > properly on receive. Good point. It will fail if one uses AUTH due to the reason I mentioned for GRO. I have to split the GSO packet upon rx too and that should do it. Will post a v2 when I have it. Thanks, Marcelo