From: David Miller <davem@davemloft.net>
To: marcelo.leitner@gmail.com
Cc: netdev@vger.kernel.org, nhorman@tuxdriver.com,
vyasevich@gmail.com, linux-sctp@vger.kernel.org,
lucien.xin@gmail.com
Subject: Re: [PATCH net-next] sctp: recvmsg should be able to run even if sock is in closing state
Date: Sun, 17 Jul 2016 05:02:30 +0000 [thread overview]
Message-ID: <20160716.220230.1568654523682522363.davem@davemloft.net> (raw)
In-Reply-To: <0250eb38e3e6f219ac353fa64dc8438d91740a31.1468609937.git.marcelo.leitner@gmail.com>
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Fri, 15 Jul 2016 16:38:19 -0300
> Commit d46e416c11c8 missed to update some other places which checked for
> the socket being TCP-style AND Established state, as Closing state has
> some overlapping with the previous understanding of Established.
>
> Without this fix, one of the effects is that some already queued rx
> messages may not be readable anymore depending on how the association
> teared down, and sending may also not be possible if peer initiated the
> shutdown.
>
> Also merge two if() blocks into one condition on sctp_sendmsg().
>
> Cc: Xin Long <lucien.xin@gmail.com>
> Fixes: d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received")
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied.
prev parent reply other threads:[~2016-07-17 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:38 [PATCH net-next] sctp: recvmsg should be able to run even if sock is in closing state Marcelo Ricardo Leitner
2016-07-17 5:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716.220230.1568654523682522363.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).