From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
daniel@iogearbox.net, davem@davemloft.net
Subject: Re: [PATCH net-next] sctp: support ipv6 nonlocal bind
Date: Fri, 22 Jul 2016 13:31:56 +0000 [thread overview]
Message-ID: <20160722133156.GD9950@localhost.localdomain> (raw)
In-Reply-To: <b3a6fd04f36bcfc5557d70ba79cddfc9c5d33b3c.1469180331.git.lucien.xin@gmail.com>
On Fri, Jul 22, 2016 at 05:38:51PM +0800, Xin Long wrote:
> This patch makes sctp support ipv6 nonlocal bind by adding
> sp->inet.freebind and net->ipv6.sysctl.ip_nonlocal_bind
> check in sctp_v6_available as what sctp did to support
> ipv4 nonlocal bind (commit cdac4e077489).
Next time please mention the commit summary, e.g.
cdac4e077489 ("[SCTP] Add support for ip_nonlocal_bind sysctl &
IP_FREEBIND socket option")
For now I think we can infer it from the changelog just fine, unless
Dave thinks otherwise.
>
> Reported-by: Shijoe George <spanjikk@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/ipv6.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index ae6f1a2..660c4a4 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -560,6 +560,7 @@ static int sctp_v6_is_any(const union sctp_addr *addr)
> static int sctp_v6_available(union sctp_addr *addr, struct sctp_sock *sp)
> {
> int type;
> + struct net *net = sock_net(&sp->inet.sk);
> const struct in6_addr *in6 = (const struct in6_addr *)&addr->v6.sin6_addr;
>
> type = ipv6_addr_type(in6);
> @@ -574,7 +575,8 @@ static int sctp_v6_available(union sctp_addr *addr, struct sctp_sock *sp)
> if (!(type & IPV6_ADDR_UNICAST))
> return 0;
>
> - return ipv6_chk_addr(sock_net(&sp->inet.sk), in6, NULL, 0);
> + return sp->inet.freebind || net->ipv6.sysctl.ip_nonlocal_bind ||
> + ipv6_chk_addr(net, in6, NULL, 0);
> }
>
> /* This function checks if the address is a valid address to be used for
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-07-22 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 9:38 [PATCH net-next] sctp: support ipv6 nonlocal bind Xin Long
2016-07-22 13:31 ` Marcelo Ricardo Leitner [this message]
2016-07-25 17:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722133156.GD9950@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).