From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Mon, 25 Jul 2016 17:56:46 +0000 Subject: Re: [PATCH net-next] sctp: use inet_recvmsg to support sctp RFS well Message-Id: <20160725.105646.945632034160752030.davem@davemloft.net> List-Id: References: <75f49fcd6f30e7ec41dc0f8e39983a9579386e49.1469193942.git.lucien.xin@gmail.com> In-Reply-To: <75f49fcd6f30e7ec41dc0f8e39983a9579386e49.1469193942.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, vyasevich@gmail.com, daniel@iogearbox.net From: Xin Long Date: Fri, 22 Jul 2016 21:25:42 +0800 > Commit 486bdee0134c ("sctp: add support for RPS and RFS") > saves skb->hash into sk->sk_rxhash so that the inet_* can > record it to flow table. > > But sctp uses sock_common_recvmsg as .recvmsg instead > of inet_recvmsg, sock_common_recvmsg doesn't invoke > sock_rps_record_flow to record the flow. It may cause > that the receiver has no chances to record the flow if > it doesn't send msg or poll the socket. > > So this patch fixes it by using inet_recvmsg as .recvmsg > in sctp. > > Fixes: 486bdee0134c ("sctp: add support for RPS and RFS") > Signed-off-by: Xin Long Applied.