From: David Miller <davem@davemloft.net>
To: marcelo.leitner@gmail.com
Cc: netdev@vger.kernel.org, vyasevich@gmail.com,
nhorman@tuxdriver.com, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next] sctp: also point GSO head_skb to the sk when it's available
Date: Mon, 25 Jul 2016 18:25:01 +0000 [thread overview]
Message-ID: <20160725.112501.2010684051493485788.davem@davemloft.net> (raw)
In-Reply-To: <aa37c8d65d8d304be73f6c237202760978ec124f.1469244494.git.marcelo.leitner@gmail.com>
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Sat, 23 Jul 2016 00:33:44 -0300
> The head skb for GSO packets won't travel through the inner depths of
> SCTP stack as it doesn't contain any chunks on it. That means skb->sk
> doesn't get set and then when sctp_recvmsg() calls
> sctp_inet6_skb_msgname() on the head_skb it panics, as this last needs
> to check flags at the socket (sp->v4mapped).
>
> The fix is to initialize skb->sk for th head skb once we are able to do
> it. That is, when the first chunk is processed.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied.
prev parent reply other threads:[~2016-07-25 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 3:33 [PATCH net-next] sctp: also point GSO head_skb to the sk when it's available Marcelo Ricardo Leitner
2016-07-25 18:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725.112501.2010684051493485788.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).