From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Sat, 30 Jul 2016 13:22:10 +0000 Subject: Re: [PATCH net] sctp: allow receiving msg when TCP-style sk is in CLOSED state Message-Id: <20160730132210.GC2957@localhost.localdomain> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, davem@davemloft.net, Vlad Yasevich , daniel@iogearbox.net On Sat, Jul 30, 2016 at 02:14:41PM +0800, Xin Long wrote: > Commit 141ddefce7c8 ("sctp: change sk state to CLOSED instead of > CLOSING in sctp_sock_migrate") changed sk state to CLOSED if the > assoc is closed when sctp_accept clones a new sk. > > If there is still data in sk receive queue, users will not be able > to read it any more, as sctp_recvmsg returns directly if sk state > is CLOSED. > > This patch is to add CLOSED state check in sctp_recvmsg to allow > reading data from TCP-style sk with CLOSED state as what TCP does. > > Signed-off-by: Xin Long So scripts can track this later more easily, Fixes: 141ddefce7c8 ("sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate") Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/socket.c b/net/sctp/socket.c > index 8812e1b..9fc417a 100644 > --- a/net/sctp/socket.c > +++ b/net/sctp/socket.c > @@ -2079,7 +2079,7 @@ static int sctp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, > lock_sock(sk); > > if (sctp_style(sk, TCP) && !sctp_sstate(sk, ESTABLISHED) && > - !sctp_sstate(sk, CLOSING)) { > + !sctp_sstate(sk, CLOSING) && !sctp_sstate(sk, CLOSED)) { > err = -ENOTCONN; > goto out; > } > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >