From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Mon, 16 Jan 2017 18:50:33 +0000 Subject: Re: [PATCHv3 net-next 1/7] sctp: add a common helper function to generate stream reconf chunk Message-Id: <20170116.135033.773805315875747960.davem@davemloft.net> List-Id: References: <5f8a7d818b5db99f2ff2a791a451b311c09fad7f.1484334002.git.lucien.xin@gmail.com> In-Reply-To: <5f8a7d818b5db99f2ff2a791a451b311c09fad7f.1484334002.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com, vyasevich@gmail.com From: Xin Long Date: Sat, 14 Jan 2017 03:15:35 +0800 > diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c > index a15d824..fd58097 100644 > --- a/net/sctp/sm_make_chunk.c > +++ b/net/sctp/sm_make_chunk.c > @@ -3526,3 +3526,36 @@ struct sctp_chunk *sctp_make_fwdtsn(const struct sctp_association *asoc, > > return retval; > } > + > +/* RE-CONFIG 3.1 (RE-CONFIG chunk) > + * 0 1 2 3 > + * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 > + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > + * | Type = 130 | Chunk Flags | Chunk Length | > + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > + * \ \ > + * / Re-configuration Parameter / > + * \ \ > + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > + * \ \ > + * / Re-configuration Parameter (optional) / > + * \ \ > + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > + */ > +static struct sctp_chunk *sctp_make_reconf( > + const struct sctp_association *asoc, > + int length) > +{ > + struct sctp_reconf_chunk *reconf; This patch will cause a warning because this new static function is unused. All patch series must be fully bisectable, that measn at each step of the patch series the tree must work properly and not introduce new build warnings or build failures.