* [PATCH net-next] sctp: remove unused var from sctp_process_asconf
@ 2017-01-13 20:27 Marcelo Ricardo Leitner
2017-01-16 13:13 ` Neil Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcelo Ricardo Leitner @ 2017-01-13 20:27 UTC (permalink / raw)
To: netdev; +Cc: linux-sctp, Vlad Yasevich, Neil Horman
Assigned but not used.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
net/sctp/sm_make_chunk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index a15d824a313d310ed03ba77055d22b1c7c9d0662..80a9088084ac0d1116bf983fad9a0cdfddeefe44 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -3210,7 +3210,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
union sctp_params param;
sctp_addiphdr_t *hdr;
union sctp_addr_param *addr_param;
- sctp_addip_param_t *asconf_param;
struct sctp_chunk *asconf_ack;
__be16 err_code;
int length = 0;
@@ -3230,7 +3229,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
* asconf parameter.
*/
length = ntohs(addr_param->p.length);
- asconf_param = (void *)addr_param + length;
chunk_len -= length;
/* create an ASCONF_ACK chunk.
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf
2017-01-13 20:27 [PATCH net-next] sctp: remove unused var from sctp_process_asconf Marcelo Ricardo Leitner
@ 2017-01-16 13:13 ` Neil Horman
2017-01-16 14:40 ` Xin Long
2017-01-16 18:52 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2017-01-16 13:13 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev, linux-sctp, Vlad Yasevich
On Fri, Jan 13, 2017 at 06:27:33PM -0200, Marcelo Ricardo Leitner wrote:
> Assigned but not used.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/sm_make_chunk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index a15d824a313d310ed03ba77055d22b1c7c9d0662..80a9088084ac0d1116bf983fad9a0cdfddeefe44 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3210,7 +3210,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
> union sctp_params param;
> sctp_addiphdr_t *hdr;
> union sctp_addr_param *addr_param;
> - sctp_addip_param_t *asconf_param;
> struct sctp_chunk *asconf_ack;
> __be16 err_code;
> int length = 0;
> @@ -3230,7 +3229,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
> * asconf parameter.
> */
> length = ntohs(addr_param->p.length);
> - asconf_param = (void *)addr_param + length;
> chunk_len -= length;
>
> /* create an ASCONF_ACK chunk.
> --
> 2.9.3
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf
2017-01-13 20:27 [PATCH net-next] sctp: remove unused var from sctp_process_asconf Marcelo Ricardo Leitner
2017-01-16 13:13 ` Neil Horman
@ 2017-01-16 14:40 ` Xin Long
2017-01-16 18:52 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Xin Long @ 2017-01-16 14:40 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, linux-sctp, Vlad Yasevich, Neil Horman
On Sat, Jan 14, 2017 at 4:27 AM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> Assigned but not used.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/sm_make_chunk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index a15d824a313d310ed03ba77055d22b1c7c9d0662..80a9088084ac0d1116bf983fad9a0cdfddeefe44 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3210,7 +3210,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
> union sctp_params param;
> sctp_addiphdr_t *hdr;
> union sctp_addr_param *addr_param;
> - sctp_addip_param_t *asconf_param;
> struct sctp_chunk *asconf_ack;
> __be16 err_code;
> int length = 0;
> @@ -3230,7 +3229,6 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
> * asconf parameter.
> */
> length = ntohs(addr_param->p.length);
> - asconf_param = (void *)addr_param + length;
> chunk_len -= length;
>
> /* create an ASCONF_ACK chunk.
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf
2017-01-13 20:27 [PATCH net-next] sctp: remove unused var from sctp_process_asconf Marcelo Ricardo Leitner
2017-01-16 13:13 ` Neil Horman
2017-01-16 14:40 ` Xin Long
@ 2017-01-16 18:52 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-01-16 18:52 UTC (permalink / raw)
To: marcelo.leitner; +Cc: netdev, linux-sctp, vyasevich, nhorman
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Fri, 13 Jan 2017 18:27:33 -0200
> Assigned but not used.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-16 18:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-13 20:27 [PATCH net-next] sctp: remove unused var from sctp_process_asconf Marcelo Ricardo Leitner
2017-01-16 13:13 ` Neil Horman
2017-01-16 14:40 ` Xin Long
2017-01-16 18:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).