* [patch net-next] sctp: fix some debug output
@ 2017-01-24 9:05 Dan Carpenter
2017-01-24 9:14 ` Marcelo Ricardo Leitner
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2017-01-24 9:05 UTC (permalink / raw)
To: Vlad Yasevich, Xin Long
Cc: Neil Horman, David S. Miller, linux-sctp, netdev, kernel-janitors
We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
it causes an off-by-one read overflow.
Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 95d7b15dad21..c5f4ed5242ac 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -159,6 +159,7 @@ static const char *const sctp_timer_tbl[] = {
"TIMEOUT_T4_RTO",
"TIMEOUT_T5_SHUTDOWN_GUARD",
"TIMEOUT_HEARTBEAT",
+ "TIMEOUT_RECONF",
"TIMEOUT_SACK",
"TIMEOUT_AUTOCLOSE",
};
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch net-next] sctp: fix some debug output
2017-01-24 9:05 [patch net-next] sctp: fix some debug output Dan Carpenter
@ 2017-01-24 9:14 ` Marcelo Ricardo Leitner
2017-01-24 9:51 ` Dan Carpenter
2017-01-24 10:50 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Marcelo Ricardo Leitner @ 2017-01-24 9:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Vlad Yasevich, Xin Long, Neil Horman, David S. Miller, linux-sctp,
netdev, kernel-janitors, Colin King
On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote:
> We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
> it causes an off-by-one read overflow.
>
> Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Weird, seems your patch is missing the --- marker here.
Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 95d7b15dad21..c5f4ed5242ac 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -159,6 +159,7 @@ static const char *const sctp_timer_tbl[] = {
> "TIMEOUT_T4_RTO",
> "TIMEOUT_T5_SHUTDOWN_GUARD",
> "TIMEOUT_HEARTBEAT",
> + "TIMEOUT_RECONF",
> "TIMEOUT_SACK",
> "TIMEOUT_AUTOCLOSE",
> };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch net-next] sctp: fix some debug output
2017-01-24 9:14 ` Marcelo Ricardo Leitner
@ 2017-01-24 9:51 ` Dan Carpenter
2017-01-24 9:52 ` Colin Ian King
2017-01-24 10:50 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2017-01-24 9:51 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: Vlad Yasevich, Xin Long, Neil Horman, David S. Miller, linux-sctp,
netdev, kernel-janitors, Colin King
On Tue, Jan 24, 2017 at 07:14:11AM -0200, Marcelo Ricardo Leitner wrote:
> On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote:
> > We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
> > it causes an off-by-one read overflow.
> >
> > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Weird, seems your patch is missing the --- marker here.
> Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.
>
Colin, if you wanted, you could CC kernel-janitors with static checker
fixes. There are several of us on that list.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch net-next] sctp: fix some debug output
2017-01-24 9:51 ` Dan Carpenter
@ 2017-01-24 9:52 ` Colin Ian King
0 siblings, 0 replies; 6+ messages in thread
From: Colin Ian King @ 2017-01-24 9:52 UTC (permalink / raw)
To: Dan Carpenter, Marcelo Ricardo Leitner
Cc: Vlad Yasevich, Xin Long, Neil Horman, David S. Miller, linux-sctp,
netdev, kernel-janitors
On 24/01/17 09:51, Dan Carpenter wrote:
> On Tue, Jan 24, 2017 at 07:14:11AM -0200, Marcelo Ricardo Leitner wrote:
>> On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote:
>>> We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
>>> it causes an off-by-one read overflow.
>>>
>>> Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> Weird, seems your patch is missing the --- marker here.
>> Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.
>>
>
> Colin, if you wanted, you could CC kernel-janitors with static checker
> fixes. There are several of us on that list.
OK, thanks for the heads-up on that Dan.
Colin
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch net-next] sctp: fix some debug output
2017-01-24 9:14 ` Marcelo Ricardo Leitner
2017-01-24 9:51 ` Dan Carpenter
@ 2017-01-24 10:50 ` Dan Carpenter
2017-01-24 13:00 ` Marcelo Ricardo Leitner
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2017-01-24 10:50 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: Vlad Yasevich, Xin Long, Neil Horman, David S. Miller, linux-sctp,
netdev, kernel-janitors, Colin King
On Tue, Jan 24, 2017 at 07:14:11AM -0200, Marcelo Ricardo Leitner wrote:
> On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote:
> > We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
> > it causes an off-by-one read overflow.
> >
> > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Weird, seems your patch is missing the --- marker here.
Are there tools that require the --- marker? I normally leave it out
when it's not required.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch net-next] sctp: fix some debug output
2017-01-24 10:50 ` Dan Carpenter
@ 2017-01-24 13:00 ` Marcelo Ricardo Leitner
0 siblings, 0 replies; 6+ messages in thread
From: Marcelo Ricardo Leitner @ 2017-01-24 13:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Vlad Yasevich, Xin Long, Neil Horman, David S. Miller, linux-sctp,
netdev, kernel-janitors, Colin King
On Tue, Jan 24, 2017 at 01:50:07PM +0300, Dan Carpenter wrote:
> On Tue, Jan 24, 2017 at 07:14:11AM -0200, Marcelo Ricardo Leitner wrote:
> > On Tue, Jan 24, 2017 at 12:05:40PM +0300, Dan Carpenter wrote:
> > > We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so
> > > it causes an off-by-one read overflow.
> > >
> > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Weird, seems your patch is missing the --- marker here.
>
> Are there tools that require the --- marker? I normally leave it out
> when it's not required.
Yeah I don't think it's required. It's usually there to split it between
changelog and non-changelog stuff like the diffstat output, which is not
there too, so it should be okay.
Marcelo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-24 13:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-24 9:05 [patch net-next] sctp: fix some debug output Dan Carpenter
2017-01-24 9:14 ` Marcelo Ricardo Leitner
2017-01-24 9:51 ` Dan Carpenter
2017-01-24 9:52 ` Colin Ian King
2017-01-24 10:50 ` Dan Carpenter
2017-01-24 13:00 ` Marcelo Ricardo Leitner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).