From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 25 Jan 2017 17:29:04 +0000 Subject: Re: [PATCH net] sctp: sctp gso should set feature with NETIF_F_SG when calling skb_segment Message-Id: <20170125.122904.176544590271598853.davem@davemloft.net> List-Id: References: <7b4d081c051650e706ffda360fdfbd4baaa1a317.1485237916.git.lucien.xin@gmail.com> In-Reply-To: <7b4d081c051650e706ffda360fdfbd4baaa1a317.1485237916.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com From: Xin Long Date: Tue, 24 Jan 2017 14:05:16 +0800 > Now sctp gso puts segments into skb's frag_list, then processes these > segments in skb_segment. But skb_segment handles them only when gs is > enabled, as it's in the same branch with skb's frags. > > Although almost all the NICs support sg other than some old ones, but > since commit 1e16aa3ddf86 ("net: gso: use feature flag argument in all > protocol gso handlers"), features &= skb->dev->hw_enc_features, and > xfrm_output_gso call skb_segment with features = 0, which means sctp > gso would call skb_segment with sg = 0, and skb_segment would not work > as expected. > > This patch is to fix it by setting features param with NETIF_F_SG when > calling skb_segment so that it can go the right branch to process the > skb's frag_list. > > Signed-off-by: Xin Long Applied, thanks.