From: David Miller <davem@davemloft.net>
To: marcelo.leitner@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
vyasevich@gmail.com, nhorman@tuxdriver.com,
David.Laight@ACULAB.COM
Subject: Re: [PATCH net-next] sctp: drop __packed from almost all SCTP structures
Date: Tue, 07 Feb 2017 19:11:23 +0000 [thread overview]
Message-ID: <20170207.141123.633919678220393477.davem@davemloft.net> (raw)
In-Reply-To: <bb920bcd9cec538d7fe7abc548b56606f3c836a5.1486474498.git.marcelo.leitner@gmail.com>
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Tue, 7 Feb 2017 11:37:56 -0200
> __packed is considered harmful as it potentially generates code that
> doesn't perform well and its usage should be avoided as much as
> possible.
>
> This patch drops __packed from all SCTP structures except one, which is
> sctp_signed_cookie. In there it's required, as per changelog on
> commit 9834a2bb4970 ("[SCTP]: Fix sctp_cookie alignment in the packet.").
>
> After this patch, no alignment changes neither in x86 or x86_64 and
> no exceptions were noticed during testing on both archs.
>
> Code size for SCTP module also didn't change with this patch.
>
> Cc: David Miller <davem@davemloft.net>
> Cc: David Laight <David.Laight@ACULAB.COM>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Looks great, thanks so much for following through on this!
Applied.
prev parent reply other threads:[~2017-02-07 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:37 [PATCH net-next] sctp: drop __packed from almost all SCTP structures Marcelo Ricardo Leitner
2017-02-07 19:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207.141123.633919678220393477.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).