linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings
@ 2018-07-31  8:53 Xin Long
  2018-07-31 13:20 ` Marcelo Ricardo Leitner
  2018-08-10 18:34 ` Marcelo Ricardo Leitner
  0 siblings, 2 replies; 3+ messages in thread
From: Xin Long @ 2018-07-31  8:53 UTC (permalink / raw)
  To: linux-sctp

This patchset fixes most of the warnings from the covscan of
  https://scan.coverity.com/projects/sctp-lksctp-tools

Note that we don't fix these types of warnings:
  - getchar() returned value check (medium):
    278659 (nowhere uses the returned value)

  - call close(-1)/getsockname(-1) (medium):
    278617, 278598, 278651, 278594, 278629, 278644, 278620, 278601
    (does on purpose)

  - DUMPCORE (medium):
    278611, 278626, 278653, 278663, 278641, 278591 (does on purpose)

  - call mkstemp without securely setting umask first (low):
    278636, 278634, 278628, 278616, 278603, 278589, 278647, 278625, 278610
    (low priority)

  - recvsk (high):
    278649, 278588 (false positives)

Xin Long (9):
  myftp: fix covscan warnings
  peel_client: fix covscan warnings
  peel_server: fix covscan warnings
  sctp_darn: fix covscan warnings
  sctp_test: fix covscan warnings
  sctp_xconnect: fix covscan warnings
  testlib: fix covscan warnings
  lib: fix covscan warnings
  func_tests: fix covscan warnings

 src/apps/myftp.c                       |  8 ++++++--
 src/apps/peel_client.c                 |  6 ++++--
 src/apps/peel_server.c                 | 11 ++++++++---
 src/apps/sctp_darn.c                   | 15 ++++++++++++---
 src/apps/sctp_test.c                   | 18 +++++++++++++-----
 src/apps/sctp_xconnect.c               | 18 +++++++++---------
 src/func_tests/test_1_to_1_rtoinfo.c   |  1 +
 src/func_tests/test_1_to_1_sendto.c    |  2 +-
 src/func_tests/test_sctp_sendrecvmsg.c |  2 +-
 src/func_tests/test_timetolive.c       |  2 +-
 src/lib/connectx.c                     |  6 +++---
 src/lib/sendmsg.c                      |  1 +
 src/testlib/sctputil.c                 |  1 +
 13 files changed, 61 insertions(+), 30 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings
  2018-07-31  8:53 [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings Xin Long
@ 2018-07-31 13:20 ` Marcelo Ricardo Leitner
  2018-08-10 18:34 ` Marcelo Ricardo Leitner
  1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-07-31 13:20 UTC (permalink / raw)
  To: linux-sctp

On Tue, Jul 31, 2018 at 04:53:08PM +0800, Xin Long wrote:
> This patchset fixes most of the warnings from the covscan of
>   https://scan.coverity.com/projects/sctp-lksctp-tools

Series,
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings
  2018-07-31  8:53 [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings Xin Long
  2018-07-31 13:20 ` Marcelo Ricardo Leitner
@ 2018-08-10 18:34 ` Marcelo Ricardo Leitner
  1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-08-10 18:34 UTC (permalink / raw)
  To: linux-sctp

On Tue, Jul 31, 2018 at 04:53:08PM +0800, Xin Long wrote:
> This patchset fixes most of the warnings from the covscan of
>   https://scan.coverity.com/projects/sctp-lksctp-tools

Series applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-10 18:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-31  8:53 [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings Xin Long
2018-07-31 13:20 ` Marcelo Ricardo Leitner
2018-08-10 18:34 ` Marcelo Ricardo Leitner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).