Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers

Luis Chamberlain
2024-04-23T18:31:46Z

On Tue, Apr 23, 2024 at 09:54:35AM +0200, Thomas Weißschuh wrote:
> * Patch 1 is a bugfix for the stack_erasing sysctl handler
> * Patches 2-10 change various helper functions throughout the kernel to
> be able to handle 'const ctl_table'.
> * Patch 11 changes the signatures of all proc handlers through the tree.
> Some other signatures are also adapted, for details see the commit
> message.
>
> Only patch 1 changes any code at all.
>
> The series was compile-tested on top of next-20230423 for
> i386, x86_64, arm, arm64, riscv, loongarch, s390 and m68k.
>
> The series was split from my larger series sysctl-const series [0].
> It only focusses on the proc_handlers but is an important step to be
> able to move all static definitions of ctl_table into .rodata.
>
> [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Cover letters don't need SOBS we only use them for patches.

But anyway:

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

Luis