From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8AD280018 for ; Fri, 24 Oct 2025 11:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761306270; cv=none; b=F5spva8eUStbfxqzIB+PebcfY17NuviJR6LYSQJWJ3mG2dICEXmJMHq+yc85bJbanftCLSfOu+o+mKr0qvwZI02kXNQ5b65ts1saLCrGHiv70K77X1tHtiLXQTTguIUj4Ht4yFNvUgy0VTQXUuOS+OOBwzYXY8QVNtkTigxbUIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761306270; c=relaxed/simple; bh=Ej80jl2uiwzW7Q0agNgjGQwqhc8eFg6CYRfWKq5oG7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=gHMmk0Wl+FwKGYG66tHcTKzeSAbzeZOAgPWd+DGihmGxosyqAal5M3aYoAdU4AaI07/qJ1C8uLWQUGPqXMHqJJ8oYh8Hkf6QA3VseCj6tQHJ6dCVAYM5v/OMXB7wJDRcreHqABhzCqa7YWZA95L7hQxJ8BgVUTVz6LWkDY+Z8Rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bb6Y9IxP; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bb6Y9IxP" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-33badfbd87aso409980a91.0 for ; Fri, 24 Oct 2025 04:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761306268; x=1761911068; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=zacr6gvmQ9vDqaS1O97ygNGkrRkfIl6K5RuWNpVBtP0=; b=bb6Y9IxPGuigaIbtVaYVwewQT4+j6B/dHufdTT/LSGtyCwkK4n5Rp7JV4Y8wkaVeeF B45fW4JHWOUPwSZk7uTq6GBk8mjM/FwYHes7+5JfrIAF9F+fNFzXIxoReLNykeeE95WN 3bxPfcDT87n66jQEr5ZWavXn4if2RlQsW8rNs7di2SWv2tyydeizu9wKLo0y9hQ+Ov7N wm42Ll0k8d4SdrFpLJJeDQMypiWzCCtVKMrwOcQrM/rnp4iy/7IVI0rNINbAW3ZLrWLO Jnm+hgjdTqMjBkFAAJCg7HVObFzpJoYCOb2JL0bOhYOD4tRznX8NxDJ7lVvWppqfXgnM 8faA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761306268; x=1761911068; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zacr6gvmQ9vDqaS1O97ygNGkrRkfIl6K5RuWNpVBtP0=; b=UUzbgyAz89/Q7z4tyti5CLZ/OgZm35b2GWv9v3z8ub1kdvMXE02dN4/mZi4ZF/hD95 meBUUXLRWnRGJ3/Lw53vHbkXlx1lI6JGBkWTBaGCFJpsAzX2aeWqRtGrwWEJj5MdPQGa 093gbYQxo3WOygQ6LyaMPtIxirY9cnaL2UzfksI3H0ULpEL6BqcEhtuWsbA47RftgrE7 WgqOUmEFrJnQLp+Ux53NS+UNRdZIzeqiJGHytfW4ECJUS7QAmkhFxQlxpc1sMhO3ufBX KNoSttdDkHPdC7nepZvhEZb9niqWFdZQcAUdYS6Jd+7owIYskun0JJgXKMD6TfcZ4W30 k+Zw== X-Gm-Message-State: AOJu0YzJItmfSojGWmGPv3so2f4oveJ0oPjpULpTZU6AZSOQXexYI4GX suHapsdAl9McK15gxe4BHiDbi7WcpzA6yHcVytbgKalObNh7tMcTO/Xx X-Gm-Gg: ASbGncuRnbHjeFih3CzmyS65lWtexTLiIjDpi6gW8ulHuZEf7APq8TN0lJK14BoK0PF 78FMk/0oYUQ65k3DtIZcrvLIet5no3gw3wx7HrfcZPTaJI52y2mk0wyG0MtUMQmaODoV7+igHuH 1juwC6++AMcGsg7FxiAmACDdC26u/WjWG4EihUdWlL/QSZiOuVEgo/nO4eYfs4r6ziwQ5bEcJIa JwMVM7sMTzN6oEBGD8AS8p9M8IK4hhROKlBW0SnJv1rA90bxYrSIUmgzbd+qqvTyFAA0RuBd8NJ 6uQppca6McMUMgUhleOtrJpwumiPosgIdWL3mkDpOQG9OJJz+xt7hNhFkvK1qrMI3+DQVuUJvHa EiAqGtPzlFshOl4rUuw710X6QUFusaw9Dz28+dVdomws2PYG4h/HRZEAmkdg+HEFHuZv5gD5JNp e4qtoOM6slOEkdBGpezo8yKUEi5rlvenuCFZAZ62sTow== X-Google-Smtp-Source: AGHT+IFOG4zJwYCvCSoVrrWzwKKmIiySYPYWgc4iF6gWM6N9sou9RGKgAl7ua7MJsfPaFXhK4sGlmw== X-Received: by 2002:a17:90b:1c8f:b0:335:2eee:19d7 with SMTP id 98e67ed59e1d1-33dfabaa9bfmr10185450a91.5.1761306268465; Fri, 24 Oct 2025 04:44:28 -0700 (PDT) Received: from [127.0.1.1] ([2401:4900:c912:9303:ec55:988d:afdd:e21a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33e2247a7cfsm8817027a91.11.2025.10.24.04.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 04:44:27 -0700 (PDT) From: Ranganath V N Date: Fri, 24 Oct 2025 17:14:17 +0530 Subject: [PATCH v2] net: sctp: fix KMSAN uninit-value in sctp_inq_pop Precedence: bulk X-Mailing-List: linux-sctp@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251024-kmsan_fix-v2-1-dc393cfb9071@gmail.com> X-B4-Tracking: v=1; b=H4sIAJBm+2gC/22MSw7CIBQAr9K8tRjAVKgr72Gahp/tiwIGDKlpu LvYtcuZTGaD7BK6DJdug+QKZoyhAT90YBYVZkfQNgZOec8oP5GHzypMd1yJkLbnQg/DmWpo/Su 5pvfXbWy8YH7H9NnXhf3sv0thhBFLpWHSaimFuM5e4fNoooex1voFaMxkOqIAAAA= To: Marcelo Ricardo Leitner , Xin Long , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+d101e12bccd4095460e7@syzkaller.appspotmail.com, Ranganath V N X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761306262; l=1755; i=vnranganath.20@gmail.com; s=20250816; h=from:subject:message-id; bh=Ej80jl2uiwzW7Q0agNgjGQwqhc8eFg6CYRfWKq5oG7k=; b=uxw4Ot7rDxrniMfFmTEyfL8btyNNpnas0ivgGVzCMdJ/z0NJGeUtYduGENI6w4tyVhUmZK3HX bOta6h5thJGC3Q6Xrkl4/8kYe8Qaf0YEQJy+isSl/NAlMgk+RgOd5dI X-Developer-Key: i=vnranganath.20@gmail.com; a=ed25519; pk=7mxHFYWOcIJ5Ls8etzgLkcB0M8/hxmOh8pH6Mce5Z1A= Fix an issue detected by syzbot: KMSAN reported an uninitialized-value access in sctp_inq_pop BUG: KMSAN: uninit-value in sctp_inq_pop The issue is actually caused by skb trimming via sk_filter() in sctp_rcv(). In the reproducer, skb->len becomes 1 after sk_filter(), which bypassed the original check: if (skb->len < sizeof(struct sctphdr) + sizeof(struct sctp_chunkhdr) + skb_transport_offset(skb)) To handle this safely, a new check should be performed after sk_filter(). Reported-by: syzbot+d101e12bccd4095460e7@syzkaller.appspotmail.com Tested-by: syzbot+d101e12bccd4095460e7@syzkaller.appspotmail.com Fixes: https://syzkaller.appspot.com/bug?extid=d101e12bccd4095460e7 Suggested-by: Xin Long Signed-off-by: Ranganath V N --- KMSAN reported an uninitialized-value access in sctp_inq_pop --- Changes in v2: - changes in commit message as per the code changes. - fixed as per the suggestion. - Link to v1: https://lore.kernel.org/r/20251023-kmsan_fix-v1-1-d08c18db8877@gmail.com --- net/sctp/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/input.c b/net/sctp/input.c index 7e99894778d4..e119e460ccde 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -190,7 +190,7 @@ int sctp_rcv(struct sk_buff *skb) goto discard_release; nf_reset_ct(skb); - if (sk_filter(sk, skb)) + if (sk_filter(sk, skb) || skb->len < sizeof(struct sctp_chunkhdr)) goto discard_release; /* Create an SCTP packet structure. */ --- base-commit: 43e9ad0c55a369ecc84a4788d06a8a6bfa634f1c change-id: 20251023-kmsan_fix-78d527b9960b Best regards, -- Ranganath V N