linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: linux-sctp@vger.kernel.org
Subject: [PATCH] sctp: fix retransmit for multi-homed endpoints
Date: Sat, 22 Aug 2009 03:10:08 +0000	[thread overview]
Message-ID: <4A8F618F.70708@cn.fujitsu.com> (raw)

When T3-rtx has expired on multi-homed endpoints, the outstanding
DATA chunks may be retransmited to different path, if there are new
outstanding DATA chunks can be transmit. Such as the following:

  Endpoint (IP=X,Y)                Endpoint (IP=M,N)
                                           <--- Send (SizeH0)
              <--------------   DATA1 (SRC=M)
                                           <--- Send (SizeH0)
                                   (DATA2 not send with Nagle Algo)
             ...T3-rtx expired...
              <--------------   DATA1 (SRC=N)
              <--------------   DATA2 (SRC=M)

DATA1 and DATA2 should be sent bundled with SRC=N. So this patch
fixed it.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 net/sctp/outqueue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index d765fc5..4109db8 100644
--- a/net/sctp/outqueue.c
+++ b/net/sctp/outqueue.c
@@ -960,7 +960,7 @@ static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout)
 				new_transport = asoc->peer.active_path;
 
 			/* Change packets if necessary.  */
-			if (new_transport != transport) {
+			if (new_transport != transport && !rtx_timeout) {
 				transport = new_transport;
 
 				/* Schedule to have this transport's
-- 
1.6.2.2





             reply	other threads:[~2009-08-22  3:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-22  3:10 Wei Yongjun [this message]
2009-08-24 14:26 ` [PATCH] sctp: fix retransmit for multi-homed endpoints Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8F618F.70708@cn.fujitsu.com \
    --to=yjwei@cn.fujitsu.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).