From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH 1/2] sctp: fix to reset packet information after packet
Date: Wed, 02 Sep 2009 14:41:43 +0000 [thread overview]
Message-ID: <4A9E8427.8020900@hp.com> (raw)
In-Reply-To: <4A9DFD1D.8050009@cn.fujitsu.com>
Wei Yongjun wrote:
> The packet information does not reset after packet transmit, this
> may cause some problems such as following DATA chunk be sent without
> AUTH chunk, even if the authentication of DATA chunk has been
> requested by the peer.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
> net/sctp/output.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index b94c211..fbbfbce 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -599,6 +599,11 @@ int sctp_packet_transmit(struct sctp_packet *packet)
>
> out:
> packet->size = packet->overhead;
> + packet->has_cookie_echo = 0;
> + packet->has_sack = 0;
> + packet->has_data = 0;
> + packet->ipfragok = 0;
> + packet->auth = NULL;
I'll stick this into sctp_packet_reset(). OK?
-vlad
> return err;
> no_route:
> kfree_skb(nskb);
prev parent reply other threads:[~2009-09-02 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 5:05 [PATCH 1/2] sctp: fix to reset packet information after packet transmit Wei Yongjun
2009-09-02 14:41 ` Vlad Yasevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9E8427.8020900@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).