linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Doug Graham" <dgraham@nortel.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH 0/2] Re: Do piggybacked ACKs work
Date: Sat, 05 Sep 2009 04:54:31 +0000	[thread overview]
Message-ID: <4AA1EF07.20009@nortel.com> (raw)
In-Reply-To: <1251131172-20602-1-git-send-email-vladislav.yasevich@hp.com>


>
> Sorry, haven't had a lot of time to play with this until now.  The 
> behaviour for
> small unfragmented message looks fine, but if the message has to be 
> fragmented,
> things don't look so good.  I'm ping-ponging a 1500 byte message 
> around: client
> sends 1500 bytes, server reads that and replies with the same message, 
> client
> reads the reply then sleeps 2 seconds before doing it all over again.  
> I see no
> piggybacking happening at all.  A typical cycle looks like:
>
> 12 2.007226    10.0.0.248    10.0.0.249    SCTP     DATA  (TSN 7376)
> 13 2.007268    10.0.0.248    10.0.0.249    SCTP     DATA  (TSN 7377)
> 14 2.007313    10.0.0.249    10.0.0.248    SCTP     SACK  (TSN 7377)
> 15 2.007390    10.0.0.249    10.0.0.248    SCTP     SACK  (TSN 7377)
> 16 2.007542    10.0.0.249    10.0.0.248    SCTP     DATA
> 17 2.007567    10.0.0.249    10.0.0.248    SCTP     DATA
> 18 2.007615    10.0.0.248    10.0.0.249    SCTP     SACK
> 19 2.007661    10.0.0.248    10.0.0.249    SCTP     SACK
>
> Those back-to-back SACKs look wasteful too.  One should have done the 
> job,
> although I suppose I can't be sure that SACKs aren't crossing DATA
> on the wire.  But the real mystery is why the SACKs were
> sent immediately after the DATA was received.  Looks like delayed SACKs
> might be broken, although they are working for unfragmented messages.
>

It just occurred to me to check the TSNs too, and I've redone the annotation
in the trace above with those.  So the back-to-back SACKs are 
duplicates: both
acknowledge the second data chunk (so they could not have crossed DATA 
on the
wire).

--Doug

  parent reply	other threads:[~2009-09-05  4:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24 16:26 [PATCH 0/2] Re: Do piggybacked ACKs work Vlad Yasevich
2009-09-02  0:25 ` Doug Graham
2009-09-02 14:29 ` Vlad Yasevich
2009-09-05  4:41 ` Doug Graham
2009-09-05  4:54 ` Doug Graham [this message]
2009-09-06  2:06 ` Vlad Yasevich
2009-09-06  4:27 ` Doug Graham
2009-09-08 19:31 ` Vlad Yasevich
2009-09-08 20:21 ` Doug Graham
2009-09-08 21:05 ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA1EF07.20009@nortel.com \
    --to=dgraham@nortel.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).