linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE
@ 2009-10-13 20:35 Andrei Pelinescu-Onciul
  2009-10-14 19:51 ` Vlad Yasevich
  0 siblings, 1 reply; 2+ messages in thread
From: Andrei Pelinescu-Onciul @ 2009-10-13 20:35 UTC (permalink / raw)
  To: linux-sctp

Since draft-ietf-tsvwg-sctpsocket-15.txt, setting the
SPP_MTUD_ENABLE flag when changing pathmaxrxt via the
SCTP_PEER_ADDR_PARAMS setsockopt is not required any
longer.

Signed-off-by: Andrei Pelinescu-Onciul <andrei@iptel.org>
---
 net/sctp/socket.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 2a21d50..1b04ade 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -2300,11 +2300,10 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
 		}
 	}
 
-	/* Note that unless the spp_flag is set to SPP_PMTUD_ENABLE the value
-	 * of this field is ignored.  Note also that a value of zero
-	 * indicates the current setting should be left unchanged.
+	/* Note that a value of zero indicates the current setting should be
+	   left unchanged.
 	 */
-	if ((params->spp_flags & SPP_PMTUD_ENABLE) && params->spp_pathmaxrxt) {
+	if (params->spp_pathmaxrxt) {
 		if (trans) {
 			trans->pathmaxrxt = params->spp_pathmaxrxt;
 		} else if (asoc) {
-- 
1.6.4.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE
  2009-10-13 20:35 [PATCH] sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE Andrei Pelinescu-Onciul
@ 2009-10-14 19:51 ` Vlad Yasevich
  0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2009-10-14 19:51 UTC (permalink / raw)
  To: linux-sctp



Andrei Pelinescu-Onciul wrote:
> Since draft-ietf-tsvwg-sctpsocket-15.txt, setting the
> SPP_MTUD_ENABLE flag when changing pathmaxrxt via the
> SCTP_PEER_ADDR_PARAMS setsockopt is not required any
> longer.
> 

applied, thanks

-vlad

> Signed-off-by: Andrei Pelinescu-Onciul <andrei@iptel.org>
> ---
>  net/sctp/socket.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 2a21d50..1b04ade 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -2300,11 +2300,10 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
>  		}
>  	}
>  
> -	/* Note that unless the spp_flag is set to SPP_PMTUD_ENABLE the value
> -	 * of this field is ignored.  Note also that a value of zero
> -	 * indicates the current setting should be left unchanged.
> +	/* Note that a value of zero indicates the current setting should be
> +	   left unchanged.
>  	 */
> -	if ((params->spp_flags & SPP_PMTUD_ENABLE) && params->spp_pathmaxrxt) {
> +	if (params->spp_pathmaxrxt) {
>  		if (trans) {
>  			trans->pathmaxrxt = params->spp_pathmaxrxt;
>  		} else if (asoc) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-14 19:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 20:35 [PATCH] sctp: allow setting path_maxrxt independent of SPP_PMTUD_ENABLE Andrei Pelinescu-Onciul
2009-10-14 19:51 ` Vlad Yasevich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).