From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xufeng Zhang Date: Fri, 25 Apr 2014 08:49:20 +0000 Subject: Re: [PATCH] sctp: reset flowi4_oif parameter on route lookup Message-Id: <535A2190.6020801@windriver.com> List-Id: References: <1398410978-15954-1-git-send-email-xufeng.zhang@windriver.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Anastasov Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org On 04/25/2014 03:57 PM, Julian Anastasov wrote: > Hello, > > On Fri, 25 Apr 2014, Xufeng Zhang wrote: > > >> >> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c >> index c09757f..f8a5968 100644 >> --- a/net/sctp/protocol.c >> +++ b/net/sctp/protocol.c >> @@ -493,6 +493,10 @@ static void sctp_v4_get_dst(struct sctp_transport *t, union sctp_addr *saddr, >> (AF_INET = laddr->a.sa.sa_family)) { >> fl4->saddr = laddr->a.v4.sin_addr.s_addr; >> fl4->fl4_sport = laddr->a.v4.sin_port; >> + /* Reset flowi4_oif so that it won't be incorrectly used >> + * as input parameter to routing lookups. >> + */ >> + fl4->flowi4_oif = 0; >> > May be something like this is more correct: > > flowi4_update_output(fl4, > asoc->base.sk->sk_bound_dev_if, > RT_CONN_FLAGS(asoc->base.sk), > daddr->v4.sin_addr.s_addr, > laddr->a.v4.sin_addr.s_addr); > Thanks! you are right, I should use the available API. I'll send V2 later. Thanks, Xufeng > >> rt = ip_route_output_key(sock_net(sk), fl4); >> if (!IS_ERR(rt)) { >> dst =&rt->dst; >> > Regards > > -- > Julian Anastasov > >