public inbox for linux-sctp@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Vlad Yasevich' <vyasevich@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: [PATCH net-next] sctp: Add partially support for MSG_MORE to SCTP.
Date: Wed, 25 Jun 2014 10:28:28 +0000	[thread overview]
Message-ID: <53AAA44C.5010206@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1726152D@AcuExch.aculab.com>

On 06/23/2014 04:27 PM, David Laight wrote:
> From: Vlad Yasevich
>> On 06/20/2014 12:24 PM, David Laight wrote:
>>> If MSG_MORE is set then buffer sends as if Nagle were enabled.
>>> The first data chunk is still sent on its own, but subsequent chunks
>>> will be bundled and full packets sent.
>>> Full MSG_MORE support would require a timeout (preferably configurable
>>> per-socket) to send the last chunk(s), instead of sending them
>>> when there is nothing outstanding.
>>
>> Instead of using 1 and 2, can you define them as flags please
>
> Will do....
>
> It is worth inverting nagle/nodelay bit; so that:
> 0 => SCTP_NODELAY
> 1 => Nagle (default)
> 2 => MSG_MORE
> 4 => reserved for corked
>
> That would require working out where the structure is initialised
> (in order to default to Nagle).

I think that should be fine, too.

      reply	other threads:[~2014-06-25 10:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 16:24 [PATCH net-next] sctp: Add partially support for MSG_MORE to SCTP David Laight
2014-06-20 22:10 ` Vlad Yasevich
2014-06-23 14:27   ` David Laight
2014-06-25 10:28     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAA44C.5010206@redhat.com \
    --to=dborkman@redhat.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox