From: David Laight <David.Laight@ACULAB.COM>
To: 'Konstantin Khorenko' <khorenko@virtuozzo.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: "oleg.babin@gmail.com" <oleg.babin@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Xin Long <lucien.xin@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: RE: [PATCH v2 1/2] net/sctp: Make wrappers for accessing in/out streams
Date: Fri, 03 Aug 2018 16:41:38 +0000 [thread overview]
Message-ID: <64cefdadefae4961a111d442b3ee8af2@AcuMS.aculab.com> (raw)
In-Reply-To: <20180803162102.19540-2-khorenko@virtuozzo.com>
From: Konstantin Khorenko
> Sent: 03 August 2018 17:21
...
> --- a/net/sctp/stream.c
> +++ b/net/sctp/stream.c
> @@ -37,6 +37,18 @@
> #include <net/sctp/sm.h>
> #include <net/sctp/stream_sched.h>
>
> +struct sctp_stream_out *sctp_stream_out(const struct sctp_stream *stream,
> + __u16 sid)
> +{
> + return ((struct sctp_stream_out *)(stream->out)) + sid;
> +}
> +
> +struct sctp_stream_in *sctp_stream_in(const struct sctp_stream *stream,
> + __u16 sid)
> +{
> + return ((struct sctp_stream_in *)(stream->in)) + sid;
> +}
> +
Those look like they ought to be static inlines in the header file.
Otherwise you'll be making SCTP performance worse that it is already.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2018-08-03 16:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 18:41 [PATCH net-next 0/2] net/sctp: Avoid allocating high order memory with kmalloc() Oleg Babin
2018-04-23 18:41 ` [PATCH net-next 1/2] net/sctp: Make wrappers for accessing in/out streams Oleg Babin
2018-04-23 21:33 ` Marcelo Ricardo Leitner
2018-04-26 22:19 ` Oleg Babin
2018-04-23 18:41 ` [PATCH net-next 2/2] net/sctp: Replace in/out stream arrays with flex_array Oleg Babin
2018-04-23 21:33 ` [PATCH net-next 0/2] net/sctp: Avoid allocating high order memory with kmalloc() Marcelo Ricardo Leitner
2018-04-26 22:14 ` Oleg Babin
2018-04-26 22:28 ` Marcelo Ricardo Leitner
2018-04-26 22:45 ` Oleg Babin
2018-07-24 15:35 ` Konstantin Khorenko
2018-07-24 17:36 ` Marcelo Ricardo Leitner
2018-08-03 16:21 ` [PATCH v2 " Konstantin Khorenko
2018-08-03 16:21 ` [PATCH v2 1/2] net/sctp: Make wrappers for accessing in/out streams Konstantin Khorenko
2018-08-03 16:41 ` David Laight [this message]
2018-08-03 19:50 ` David Miller
2018-08-09 8:39 ` Konstantin Khorenko
2018-08-03 20:40 ` Marcelo Ricardo Leitner
2018-08-09 8:40 ` Konstantin Khorenko
2018-08-03 16:21 ` [PATCH v2 2/2] net/sctp: Replace in/out stream arrays with flex_array Konstantin Khorenko
2018-08-03 16:43 ` [PATCH v2 0/2] net/sctp: Avoid allocating high order memory with kmalloc() David Laight
2018-08-03 20:30 ` Marcelo Ricardo Leitner
2018-08-03 20:56 ` Michael Tuexen
2018-08-06 9:34 ` David Laight
2018-08-08 14:48 ` Marcelo Ricardo Leitner
2018-08-03 23:36 ` Marcelo Ricardo Leitner
2018-08-09 8:43 ` Konstantin Khorenko
2018-08-10 17:03 ` Konstantin Khorenko
2018-08-10 17:11 ` [PATCH v3 " Konstantin Khorenko
2018-08-10 17:11 ` [PATCH v3 1/2] net/sctp: Make wrappers for accessing in/out streams Konstantin Khorenko
2018-08-10 17:11 ` [PATCH v3 2/2] net/sctp: Replace in/out stream arrays with flex_array Konstantin Khorenko
2018-08-11 19:36 ` [PATCH v3 0/2] net/sctp: Avoid allocating high order memory with kmalloc() David Miller
2018-08-10 17:41 ` [PATCH v2 " Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64cefdadefae4961a111d442b3ee8af2@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=aryabinin@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=khorenko@virtuozzo.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=oleg.babin@gmail.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).