From: Florian Westphal <fw@strlen.de>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Yi Chen <yiche@redhat.com>
Subject: Re: [PATCH net 1/2] netfilter: skip recording stale or retransmitted INIT
Date: Sat, 11 Apr 2026 22:16:18 +0200 [thread overview]
Message-ID: <adqsEmki7ppz9T1g@strlen.de> (raw)
In-Reply-To: <6e09f9a8d1f13f3ce691c696d3dd7b2a2e6c6184.1775847557.git.lucien.xin@gmail.com>
Xin Long <lucien.xin@gmail.com> wrote:
> diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c
> index 645d2c43ebf7..7e10fa65cbdd 100644
> --- a/net/netfilter/nf_conntrack_proto_sctp.c
> +++ b/net/netfilter/nf_conntrack_proto_sctp.c
> @@ -466,9 +466,13 @@ int nf_conntrack_sctp_packet(struct nf_conn *ct,
> if (!ih)
> goto out_unlock;
>
> - if (ct->proto.sctp.init[dir] && ct->proto.sctp.init[!dir])
> - ct->proto.sctp.init[!dir] = 0;
> - ct->proto.sctp.init[dir] = 1;
> + /* Do not record INIT matching peer vtag (stale or retransmitted INIT). */
> + if (old_state == SCTP_CONNTRACK_NONE ||
> + ct->proto.sctp.vtag[!dir] != ih->init_tag) {
Should ct->proto.sctp.vtag[!dir] == ih->init_tag case also
set ignore = true?
next prev parent reply other threads:[~2026-04-11 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 18:59 [PATCH net 0/2] sctp: fix a vtag verification failure caused by stale INITs Xin Long
2026-04-10 18:59 ` [PATCH net 1/2] netfilter: skip recording stale or retransmitted INIT Xin Long
2026-04-11 20:16 ` Florian Westphal [this message]
2026-04-10 18:59 ` [PATCH net 2/2] sctp: discard stale INIT after handshake completion Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adqsEmki7ppz9T1g@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yiche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox