From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: David Howells <dhowells@redhat.com>, Vasily Averin <vvs@virtuozzo.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH 1/1] proc_keys_next should increase position index
Date: Thu, 30 Jan 2020 10:42:21 +0200 [thread overview]
Message-ID: <0683e4921abc42f94800b3a91490a39bbb7d4cb1.camel@linux.intel.com> (raw)
In-Reply-To: <1451508.1580125174@warthog.procyon.org.uk>
On Mon, 2020-01-27 at 11:39 +0000, David Howells wrote:
> I don't see the effect you're talking about with /proc/keys. I see the
> following:
>
> [root@andromeda ~]# dd if=/proc/keys bs=40 skip=1
> dd: /proc/keys: cannot skip to specified offset
>
> and then it follows up with the normal content with no obvious duplicates (the
> lines are numbered ascendingly in the first column).
>
> I think I may be being confused by what you mean by "the last line".
>
> David
The commit message is completely lacking cause and effect. For
similar TPM commit I gave the following remarks:
https://patchwork.kernel.org/patch/11346943/
/Jarkko
next prev parent reply other threads:[~2020-01-30 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 6:25 [PATCH 1/1] proc_keys_next should increase position index Vasily Averin
2020-01-27 11:39 ` David Howells
2020-01-27 19:27 ` Vasily Averin
2020-01-30 10:16 ` [PATCH v2] keys: " Vasily Averin
2020-01-31 17:19 ` David Howells
2020-02-01 7:54 ` Vasily Averin
2020-01-30 8:42 ` Jarkko Sakkinen [this message]
2020-01-30 8:38 ` [PATCH 1/1] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0683e4921abc42f94800b3a91490a39bbb7d4cb1.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).