From: Shuah Khan <skhan@linuxfoundation.org>
To: Gautam <gautammenghani201@gmail.com>,
shuah@kernel.org, brauner@kernel.org, keescook@chromium.org
Cc: kafai@fb.com, songliubraving@fb.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-security-module@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kselftests: Enable the echo command to print newlines in Makefile
Date: Mon, 27 Jun 2022 11:03:52 -0600 [thread overview]
Message-ID: <0c6c6966-0164-12b5-f73f-1ecf157e196f@linuxfoundation.org> (raw)
In-Reply-To: <20220625135455.167939-1-gautammenghani201@gmail.com>
On 6/25/22 7:54 AM, Gautam wrote:
> In the install section of the main Makefile of kselftests, the echo
> command is used with -n flag, which disables the printing of new line
> due to which the output contains "\n" chars as follows:
>
> Emit Tests for alsa\nSkipping non-existent dir: arm64
> Emit Tests for breakpoints\nEmit Tests for capabilities\n
>
> This patch fixes the above bug by using the -e flag.
>
> Signed-off-by: Gautam <gautammenghani201@gmail.com>
> ---
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index de11992dc577..52e31437f1a3 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -253,7 +253,7 @@ ifdef INSTALL_PATH
> for TARGET in $(TARGETS); do \
> BUILD_TARGET=$$BUILD/$$TARGET; \
> [ ! -d $(INSTALL_PATH)/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \
> - echo -n "Emit Tests for $$TARGET\n"; \
> + echo -ne "Emit Tests for $$TARGET\n"; \
> $(MAKE) -s --no-print-directory OUTPUT=$$BUILD_TARGET COLLECTION=$$TARGET \
> -C $$TARGET emit_tests >> $(TEST_LIST); \
> done;
>
Thank you. Will be applied to kselftest next for Linux 5.20-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2022-06-27 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 13:54 [PATCH] kselftests: Enable the echo command to print newlines in Makefile Gautam
2022-06-27 17:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6c6966-0164-12b5-f73f-1ecf157e196f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=gautammenghani201@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).