From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE8A6C5519F for ; Fri, 20 Nov 2020 23:40:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BBD722470 for ; Fri, 20 Nov 2020 23:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="da9adWid" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbgKTXkN (ORCPT ); Fri, 20 Nov 2020 18:40:13 -0500 Received: from linux.microsoft.com ([13.77.154.182]:45274 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbgKTXkN (ORCPT ); Fri, 20 Nov 2020 18:40:13 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 5F08E20B717A; Fri, 20 Nov 2020 15:40:12 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F08E20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1605915612; bh=pm8lF2tlf3tvdq+Us/teGujaOR41+GOwf/8B1ECpHsg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=da9adWidx/Zz4+47O33LIzwsWL9VwM9KC98pw2gZ2ojU8IL67HUEK1c4E+CCzc0X7 NWIGEeFW8mwF+gDChkpQbRt7SLi/uhfaPIelOidwbNiixPz1yw35i+CXAwswMnSMtH RG+PiWZ5vm/AkFgdmseXOj5SBQEZOfAOWj3C24tU= Subject: Re: [PATCH v6 8/8] selinux: measure state and hash of the policy using IMA To: Mimi Zohar , Tushar Sugandhi , stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com Cc: tyhicks@linux.microsoft.com, sashal@kernel.org, jmorris@namei.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201119232611.30114-1-tusharsu@linux.microsoft.com> <20201119232611.30114-9-tusharsu@linux.microsoft.com> <4634c6c12b2452849f73ed2d5a4d168707e0ac9a.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: <0fb07bd3-c877-ab0f-cd45-dcfbe1fec044@linux.microsoft.com> Date: Fri, 20 Nov 2020 15:40:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4634c6c12b2452849f73ed2d5a4d168707e0ac9a.camel@linux.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On 11/20/20 7:49 AM, Mimi Zohar wrote: Hi Mimi, > > On Thu, 2020-11-19 at 15:26 -0800, Tushar Sugandhi wrote: >> From: Lakshmi Ramasubramanian >> >> IMA measures files and buffer data such as keys, command line arguments >> passed to the kernel on kexec system call, etc. While these measurements >> enable monitoring and validating the integrity of the system, it is not >> sufficient. > > The above paragraph would make a good cover letter introduction. Agreed - will add this paragraph to the cover letter as well. > >> In-memory data structures maintained by various kernel >> components store the current state and policies configured for >> the components. > > Various data structures, policies and state stored in kernel memory > also impact the integrity of the system. Will update. > > The 2nd paragraph could provide examples of such integrity critical > data. Will do. > > This patch set introduces a new IMA hook named > ima_measure_critical_data() to measure kernel integrity critical data. > *Question* I am not clear about this one - do you mean add the following line in the patch description for the selinux patch? "This patch introduces the first use of the new IMA hook namely ima_measures_critical_data() to measure the integrity critical data for SELinux" thanks, -lakshmi