From: steve@steve.fi (Steve Kemp)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2] Moved module init-functions into the module.
Date: Thu, 22 Jun 2017 17:21:24 +0000 [thread overview]
Message-ID: <1498152084.15628.1@ssh.steve.org.uk> (raw)
In-Reply-To: <CAGXu5jJb8vc3Og7Mk2LUYvnJT2tZ4_W3MRPetJWtUEpAGZupXg@mail.gmail.com>
> > The module initialization code belongs in the module.
> > The LSM infrastructure should have an absolute minimum
> > of module specific information. I would rather see the
> > "minor" modules (yama, loadpin) changed to use the module
> > registration scheme used by the "major" modules, but that
> > will require a mechanism to ensure module ordering, and
> > we don't have that yet. No, don't do this.
>
> Yeah, I agree: initialization order is important here and I don't want
> to depend on the Makefile for this.
I can appreciate that argument. I did consider it myself,
but decided that because the minor modules had such differing
goals, and no real functional overlap, in practice that would
mean that explicit ordering wasn't a strong requirement.
If/when a better registration scheme becomes available then
we'll all switch to using it, and that would be great.
Thanks for the feedback. I'll not tweak any further.
Steve
--
https://steve.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-22 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:45 [PATCH v2] Moved module init-functions into the module Steve Kemp
2017-06-22 16:54 ` Casey Schaufler
2017-06-22 16:56 ` Kees Cook
2017-06-22 17:21 ` Steve Kemp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498152084.15628.1@ssh.steve.org.uk \
--to=steve@steve.fi \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).