Linux Security Modules development
 help / color / mirror / Atom feed
From: sds@tycho.nsa.gov (Stephen Smalley)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
Date: Wed, 04 Oct 2017 16:26:18 -0400	[thread overview]
Message-ID: <1507148778.1491.10.camel@tycho.nsa.gov> (raw)
In-Reply-To: <20171004183218.4786-1-clabbe.montjoie@gmail.com>

On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch remove the unused variable sid
> This fix the following build warning:
> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
> used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

> ---
> ?security/selinux/hooks.c | 3 +--
> ?1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index f5d304736852..8507a56f85e4 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct
> inode *inode, struct inode *dir,
> ?{
> ?	const struct task_security_struct *tsec =
> current_security();
> ?	struct superblock_security_struct *sbsec;
> -	u32 sid, newsid, clen;
> +	u32 newsid, clen;
> ?	int rc;
> ?	char *context;
> ?
> ?	sbsec = dir->i_sb->s_security;
> ?
> -	sid = tsec->sid;
> ?	newsid = tsec->create_sid;
> ?
> ?	rc = selinux_determine_inode_label(current_security(),
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-10-04 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 18:32 [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Corentin Labbe
2017-10-04 18:32 ` [PATCH 2/2] selinux: fix build warning Corentin Labbe
2017-10-04 20:27   ` Stephen Smalley
2017-10-04 20:34     ` Paul Moore
2017-10-04 20:26 ` Stephen Smalley [this message]
2017-10-04 20:33   ` [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507148778.1491.10.camel@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox