From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
Date: Tue, 06 Mar 2018 13:31:21 +0200 [thread overview]
Message-ID: <1520335881.7549.9.camel@linux.intel.com> (raw)
In-Reply-To: <20180306093041.11996-4-tomas.winkler@intel.com>
On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote:
> Factor out get random implementation from tpm-interface.c
> into tpm1_get_random function in tpm1-cmd.c.
> No functional changes.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
While you are doing this, please make it use tpm_buf so tha we get stuff
out of that nasty union. Using "helper" structs is still fine, just move
it right before the function implementation out of tpm.h (there are
examples of this tpm2-cmd.c).
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-06 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 9:30 [PATCH 0/4] tpm: factor out tpm1 code into tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` [PATCH 1/4] tmp: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` [PATCH 2/4] tmp: move tpm_getcap " Tomas Winkler
2018-03-06 9:30 ` [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-03-06 11:31 ` Jarkko Sakkinen [this message]
2018-03-06 11:34 ` Winkler, Tomas
2018-03-06 13:56 ` Jarkko Sakkinen
2018-03-06 9:30 ` [PATCH 4/4] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c Tomas Winkler
2018-03-06 11:32 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520335881.7549.9.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).