From: James.Bottomley@HansenPartnership.com (James Bottomley)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] tpm: add support for partial reads
Date: Mon, 23 Jul 2018 14:13:32 -0700 [thread overview]
Message-ID: <1532380412.4112.22.camel@HansenPartnership.com> (raw)
In-Reply-To: <fb053916-f6e8-3266-14d7-128e062b6a92@intel.com>
On Mon, 2018-07-23 at 13:53 -0700, Tadeusz Struk wrote:
> On 07/23/2018 01:19 PM, Jarkko Sakkinen wrote:
> > In this case I do not have any major evidence of any major benefit
> > *and* the change breaks the ABI.
>
> As I said before - this does not break the ABI.
The current patch does, you even provided a use case in your last email
(it's do command to get sizing followed by do command with correctly
sized buffer).?
However, if you tie it to O_NONBLOCK, it won't because no-one currently
opens the TPM device non blocking so it's an ABI conformant
discriminator of the uses. Tying to O_NONBLOCK should be simple
because it's in file->f_flags.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-23 21:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 15:52 [PATCH] tpm: add support for partial reads Tadeusz Struk
2018-07-19 15:55 ` Tadeusz Struk
2018-07-19 17:19 ` James Bottomley
2018-07-19 17:54 ` Tadeusz Struk
2018-07-19 18:47 ` James Bottomley
2018-07-19 19:05 ` Tadeusz Struk
2018-07-19 19:52 ` James Bottomley
2018-07-19 20:12 ` Tadeusz Struk
2018-07-19 20:27 ` James Bottomley
2018-07-19 21:01 ` Tadeusz Struk
2018-07-23 20:19 ` Jarkko Sakkinen
2018-07-23 20:53 ` Tadeusz Struk
2018-07-23 21:13 ` James Bottomley [this message]
2018-07-23 21:38 ` Tadeusz Struk
2018-07-23 21:56 ` Jason Gunthorpe
2018-07-23 22:00 ` Tadeusz Struk
2018-07-23 22:08 ` Jason Gunthorpe
2018-07-23 23:42 ` Tadeusz Struk
2018-07-24 2:05 ` Jason Gunthorpe
2018-07-23 21:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532380412.4112.22.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).