Linux Security Modules development
 help / color / mirror / Atom feed
From: Alan Maguire <alan.maguire@oracle.com>
To: skhan@linuxfoundation.org, brendanhiggins@google.com,
	gregkh@linuxfoundation.org
Cc: rafael@kernel.org, jmorris@namei.org, serge@hallyn.com,
	knut.omang@oracle.com, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	sfr@canb.auug.org.au, Alan Maguire <alan.maguire@oracle.com>
Subject: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig
Date: Fri, 10 Jan 2020 11:49:25 +0000	[thread overview]
Message-ID: <1578656965-2993-1-git-send-email-alan.maguire@oracle.com> (raw)

kunit tests that do not support module build should depend
on KUNIT=y rather than just KUNIT in Kconfig, otherwise
they will trigger compilation errors for "make allmodconfig"
builds.

Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/base/Kconfig      | 2 +-
 security/apparmor/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index c3b3b5c..5f0bc74 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -150,7 +150,7 @@ config DEBUG_TEST_DRIVER_REMOVE
 
 config PM_QOS_KUNIT_TEST
 	bool "KUnit Test for PM QoS features"
-	depends on KUNIT
+	depends on KUNIT=y
 
 config HMEM_REPORTING
 	bool
diff --git a/security/apparmor/Kconfig b/security/apparmor/Kconfig
index d547930..0fe3368 100644
--- a/security/apparmor/Kconfig
+++ b/security/apparmor/Kconfig
@@ -71,7 +71,7 @@ config SECURITY_APPARMOR_DEBUG_MESSAGES
 
 config SECURITY_APPARMOR_KUNIT_TEST
 	bool "Build KUnit tests for policy_unpack.c"
-	depends on KUNIT && SECURITY_APPARMOR
+	depends on KUNIT=y && SECURITY_APPARMOR
 	help
 	  This builds the AppArmor KUnit tests.
 
-- 
1.8.3.1


             reply	other threads:[~2020-01-10 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 11:49 Alan Maguire [this message]
2020-01-10 21:39 ` [PATCH kunit] kunit: building kunit as a module breaks allmodconfig Shuah Khan
2020-01-14  2:18   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1578656965-2993-1-git-send-email-alan.maguire@oracle.com \
    --to=alan.maguire@oracle.com \
    --cc=brendanhiggins@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmorris@namei.org \
    --cc=knut.omang@oracle.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=serge@hallyn.com \
    --cc=sfr@canb.auug.org.au \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox