From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D54C33CA9 for ; Sun, 12 Jan 2020 15:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57B7721556 for ; Sun, 12 Jan 2020 15:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733063AbgALPhV (ORCPT ); Sun, 12 Jan 2020 10:37:21 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58884 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733068AbgALPhV (ORCPT ); Sun, 12 Jan 2020 10:37:21 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00CFb55Y013521 for ; Sun, 12 Jan 2020 10:37:20 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xfvq4ahbe-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 12 Jan 2020 10:37:20 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 12 Jan 2020 15:37:18 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 12 Jan 2020 15:37:13 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 00CFbCcO11862282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 12 Jan 2020 15:37:12 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3D9F4AE045; Sun, 12 Jan 2020 15:37:12 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E23E4AE051; Sun, 12 Jan 2020 15:37:10 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.200.88]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 12 Jan 2020 15:37:10 +0000 (GMT) Subject: Re: [PATCH v13 26/25] Audit: Multiple LSM support in audit rules From: Mimi Zohar To: Casey Schaufler , casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, "linux-audit@redhat.com" , linux-integrity@vger.kernel.org Date: Sun, 12 Jan 2020 10:37:10 -0500 In-Reply-To: References: <20191224235939.7483-1-casey.ref@schaufler-ca.com> <20191224235939.7483-1-casey@schaufler-ca.com> <1578587607.5147.63.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20011215-0008-0000-0000-00000348B768 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20011215-0009-0000-0000-00004A690461 Message-Id: <1578843430.4546.45.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-01-12_05:2020-01-10,2020-01-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001120148 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Fri, 2020-01-10 at 11:40 -0800, Casey Schaufler wrote: > On 1/9/2020 8:33 AM, Mimi Zohar wrote: > > Hi Casey, > > > > On Fri, 2020-01-03 at 10:53 -0800, Casey Schaufler wrote: > >> With multiple possible security modules supporting audit rule > >> it is necessary to keep separate data for each module in the > >> audit rules. This affects IMA as well, as it re-uses the audit > >> rule list mechanisms. > > While reviewing this patch, I realized there was a bug in the base IMA > > code.  With Janne's bug fix, that he just posted, I think this patch > > can now be simplified. > > How and when do you plan to get Janne's fix in? It's looking like > stacking won't be in for 5.6. The patch is now in the next-integrity-testing branch.  We'll see how it goes. > > > My main concern is the number of warning messages that will be > > generated.  Any time a new LSM policy is loaded, the labels will be > > re-evaulated whether or not they are applicable to the particular LSM, > > causing unnecessary warnings. > > Uhg.