From: Christian Brauner <brauner@kernel.org>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-security-module@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND] fs_context: drop the unused lsm_flags member
Date: Thu, 16 Mar 2023 14:46:17 +0100 [thread overview]
Message-ID: <167897413798.1242423.2984314832830103642.b4-ty@kernel.org> (raw)
In-Reply-To: <20230316130751.334227-1-omosnace@redhat.com>
From: Christian Brauner (Microsoft) <brauner@kernel.org>
On Thu, 16 Mar 2023 14:07:51 +0100, Ondrej Mosnacek wrote:
> This isn't ever used by VFS now, and it couldn't even work. Any FS that
> uses the SECURITY_LSM_NATIVE_LABELS flag needs to also process the
> value returned back from the LSM, so it needs to do its
> security_sb_set_mnt_opts() call on its own anyway.
>
>
Seems indeed unused currently. I don't see fc->lsm_flags being used after
having been set. So applied. Please yell, if there's some subtle place where
this should matter after all,
tree: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git
branch: fs.misc
[1/1] fs_context: drop the unused lsm_flags member
commit: 4e04143c869c5b6d499fbd5083caa860d5c942c3
prev parent reply other threads:[~2023-03-16 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 13:07 [PATCH RESEND] fs_context: drop the unused lsm_flags member Ondrej Mosnacek
2023-03-16 13:46 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167897413798.1242423.2984314832830103642.b4-ty@kernel.org \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox