From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 637DECA9ECF for ; Thu, 31 Oct 2019 15:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 391E82087F for ; Thu, 31 Oct 2019 15:13:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JCWvVvf5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfJaPNZ (ORCPT ); Thu, 31 Oct 2019 11:13:25 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29953 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726566AbfJaPNZ (ORCPT ); Thu, 31 Oct 2019 11:13:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572534804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNwFRZjnDpMMCUFzfJOSVzkAkD/c1c7Ojt9o9rhUq2Y=; b=JCWvVvf5oZCfaCc2MILyW8wczP4trc9j6Q9f1ZIvY5XV/pCboqjLEW9Mj50ctSUlqUZGQX AQGim9hY8yXRwmIbcGcdaVE2wOZXf//DRyoscxReG8qbGgsaOeVGxapWDyz4Zoa29vnLqB EC464kKiZod7MCakjOYiJQFbq4nQp/g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-jD0V8FpeNOqkFxE4eETZKg-1; Thu, 31 Oct 2019 11:13:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 839B11800D6B; Thu, 31 Oct 2019 15:13:20 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-40.rdu2.redhat.com [10.10.121.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97A915DA7D; Thu, 31 Oct 2019 15:13:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20191027152223.GA21194@infradead.org> References: <20191027152223.GA21194@infradead.org> <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> <30394.1571936252@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, torvalds@linux-foundation.org, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 11/10] pipe: Add fsync() support [ver #2] MIME-Version: 1.0 Content-ID: <17041.1572534796.1@warthog.procyon.org.uk> Date: Thu, 31 Oct 2019 15:13:16 +0000 Message-ID: <17042.1572534796@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: jD0V8FpeNOqkFxE4eETZKg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Christoph Hellwig wrote: > I am _really_ worried about overloading fsync for this behavior. fsync > hasn't done anything for 50 years, and suddenly adding any action > is not helpful. If you can't use FIONREAD please add a new ioctls > instead, and document it properly. Okay. David