From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7C9476056 for ; Thu, 15 Oct 2026 23:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792106068; cv=none; b=QZQwFJ5d+qfSHXy5qh2L55B+ii/euVwuloa1V3FLaUF5ZXTVccHc+WppnGuYCiIvMkCyv7NwwF4g+ZXYtmoZd8j8ew3GpHoDMjXU18rtBuSvoktRUVOzwFKQbQWkhdg3LEiPK7wHGDmzGfOJ4dbq+cUIu+eroC0zM9H4nTlFMPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792106068; c=relaxed/simple; bh=G1VWVzqgtNFSdZ3tdadaIkj4EZd0Y1m8BQMjwsAXmlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=iw1qXKpjNy42vSbXKprd7upPOdBuyu+fHTy7lwrovCHij10fTtQow5Xoirudn4iPNmUkUpzpSwIhpfU1MVSrnwCwoWC2QQuNNIEgDvE2Q6Roy9VXpx8AIOGrW18eP6Uth7o+yMPOUu95iuB8EocYrDMH8Wv9I77/LUk6qUGGIlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JdP5ygMa; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JdP5ygMa" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-33bf40b0c8bso878448eec.0 for ; Thu, 15 Oct 2026 16:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792106067; x=1792710867; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jOoDNdgbqEONnRhnyuTwsgaYEHRZvbrYhwZMQUhYOFM=; b=JdP5ygMabZzBXo/EhxT/jY54OXwwD04A5YDYkGO9VGJ8b8ex+IiKtzkqK1jeYDubXT DzU6iWEr9axaUr/iHLODfTVN5O3TezmRwrPsZU8by2WJMnoxetK9POQJFnkjC0jgayPz QYKL2vy+oBJgItG/6kiJ5ONqpgIL8Dmplfw8MDVc8zQg/gQz3gu4w+cqigudhqv6d3L0 rsPbhGUtoJ1zEfevk+KeE++FF+RQlb362IOzvGaAgu05XXMsnqViaSH0ywdZyprgaKpL y788N0etBWTBQDpjuzCb3BRLz4/CR27C3FfHAOXhtMm0VcCiy2fbSRzd0qJHdfAssRSU D2WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792106067; x=1792710867; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jOoDNdgbqEONnRhnyuTwsgaYEHRZvbrYhwZMQUhYOFM=; b=OrA2kZcjPVkuLG+QQiXzSN4g7LKLQTM38GfkNjs2b7MH3Bi4WdV30M9jq/tKHHoV2c rz6sEPiH8fAHSd8Ij1+P/KtJztvWJIBID5dLuJdbwbl7XBg7m8/iBd7Jm+zxbjDiIsQz Oee89rwSRwzKS9a0K56A9bmm9ztauvTJlZzTsdNykqZ/J26ty81yn/hYxsWxdLCnUeeb IdbUGD6LC6udmQGYBKXCVgLVK5Ldnq3eRg7KKVX/SP49U8gOdwac9TZexP98Cr4pw8hK o5qi4RmFV5q9kvEbqRZszuVI0NaC8kgejEobTKP72osL9Y+0o1C7Fl7klhNvYOATUVTm 1naA== X-Forwarded-Encrypted: i=1; AKwUvBw3x5J5VN2Elpn+wl5FVefcoMq4oVgBBjuw88HJ3+xBKu5T6Q1IcqdAAu3n1Ae1LFn7mxc6VaY0TaL1zvIgOgM3M8mC0zs=@vger.kernel.org X-Gm-Message-State: AFq9FYIir9LxgZe2p6rOG2EiXTLK9Ttg9DQmAZ7vvtyaZi2eX0tWI+T5 bSblCYIU059MhpPTXi7a3pAeDgD0a2Z2tHDl8rphTIKpoTyPxOLi8vTO X-Gm-Gg: AYBFou2Bv9mW4AtDw4l2WWZUSOXnplCsd9Wdf0Js3Y1nIrpSEAcf6JVvogZobvb0w+w JYi6VGnuG+y5q6eOZw14ZazbMDdHehv4jn0u1ODz6ur90JTnNJhNbUhawhUSxzL8Tb6LSkKnyq/ Pzw6T4piBjAW5oRClMpWIYtSwYi3hGOcULuQBf+HVt4+l8Lb1Vpxrw/a/wUXl0HlfpkS99jEZks NbKxwoBabArNnYIjjwxPX9G8QXurvSPdcCgSVJbrX+RMIq4JI9eKdLdsfBHl0L/RXOjw7fZfhI2 N5Lxmv+703E5CsPnbH4u96ZCikk/QK/lqX4AW9BH04D1E575dH2Pqz8kC7vDrsS5UGfOE64/7n5 uKitR0ZUplXus325rHUYIbedkKhKK0BnTtHa44p6S0tN9L00xIon/1Qro2iuQGJI9Hol+0i7Rud 4HeZ37BnZs7GraUgqzqDWjsWZhgP6jAbzqymBjV2aSvi4Tvw0+MVefTBbeo4vpX47vqBxISRbYd 1G2vagsSFvlrvFglKc4KGpTkTN8XAOZMyP9kwr6aOQQwVXrZImHAc+Mz4z66qILqZF0iQEA5bF7 J+/kOaF/cLkVGe27AJGiU2z4kq5LNiaa9zW149f2XbQfC+HTq00KO/CI0Fw/tWvEu7G6SD0= X-Received: by 2002:a05:7300:d191:b0:353:7f50:a99b with SMTP id 5a478bee46e88-3537f50ac52mr27374925eec.6.1792106066501; Thu, 15 Oct 2026 16:14:26 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2804:7f0:b100:ece0:446b:100:5c81:b436]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3607bc950f9sm1262967eec.0.2026.10.15.16.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 16:14:25 -0700 (PDT) From: Joas Antonio dos Santos To: Paolo Abeni Cc: Paul Moore , sashiko-reviews@lists.linux.dev, linux-security-module@vger.kernel.org, network dev Subject: Re: [PATCH net v2] calipso: update payload_len when removing the CALIPSO option Date: Thu, 15 Oct 2026 20:14:21 -0300 Message-ID: <179210606199.96599.8994346249690707193@gmail.com> In-Reply-To: <852c9fb6-6217-440a-968c-b5ab3e22dbc8@redhat.com> References: <179147329205.58079.5847298721173675285@gmail.com> <852c9fb6-6217-440a-968c-b5ab3e22dbc8@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 15 Oct 2026, Paolo Abeni wrote: > The above looks like a pre-existing issue, the patch itself looks > correct, right? Hi Paolo, Paul, Yes, the issue is pre-existing; the delattr patch doesn't change it. The skb_pull()/memmove()/skb_reset_network_header() sequence quoted by Sashiko predates this patch, which only adjusts payload_len after it. I tested Paul's idea on top of both CALIPSO patches (QEMU, veth + br0 with bridge-nf-call-ip6tables=1, SELinux + NetLabel CALIPSO DOI 16): - without it, a bridged CALIPSO packet towards an unlabeled destination reaches the peer with a corrupted Ethernet header (garbage dst MAC, ethertype 0x0000) and is dropped; an unlabeled packet towards a CALIPSO-mapped destination never reaches the peer. - with the nf_bridge_info_exists() check in selinux_ip_forward() (plus a stub returning false for CONFIG_BRIDGE_NETFILTER=n), 5/5 packets are delivered unmodified in both cases. - the routed path is unchanged: delattr 5/5, setattr still adds the option 5/5. W=1 is clean with BRIDGE_NETFILTER=y and =n. Paul, if you like I can send it as a separate selinux patch with your Suggested-by. Thanks, Joas