linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] apparmor: test: add MODULE_DESCRIPTION()
@ 2024-05-30  1:21 Jeff Johnson
  2024-06-20 16:21 ` Jeff Johnson
  2024-06-25  8:26 ` John Johansen
  0 siblings, 2 replies; 5+ messages in thread
From: Jeff Johnson @ 2024-05-30  1:21 UTC (permalink / raw)
  To: John Johansen, Paul Moore, James Morris, Serge E. Hallyn
  Cc: apparmor, linux-security-module, linux-kernel, kernel-janitors,
	Jeff Johnson

Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 security/apparmor/policy_unpack_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
index 5c9bde25e56d..874fcf97794e 100644
--- a/security/apparmor/policy_unpack_test.c
+++ b/security/apparmor/policy_unpack_test.c
@@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = {
 
 kunit_test_suite(apparmor_policy_unpack_test_module);
 
+MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack");
 MODULE_LICENSE("GPL");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] apparmor: test: add MODULE_DESCRIPTION()
  2024-05-30  1:21 [PATCH] apparmor: test: add MODULE_DESCRIPTION() Jeff Johnson
@ 2024-06-20 16:21 ` Jeff Johnson
  2024-06-25  8:26   ` John Johansen
  2024-06-25  8:26 ` John Johansen
  1 sibling, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-06-20 16:21 UTC (permalink / raw)
  To: John Johansen, Paul Moore, James Morris, Serge E. Hallyn
  Cc: apparmor, linux-security-module, linux-kernel, kernel-janitors

On 5/29/2024 6:21 PM, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  security/apparmor/policy_unpack_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
> index 5c9bde25e56d..874fcf97794e 100644
> --- a/security/apparmor/policy_unpack_test.c
> +++ b/security/apparmor/policy_unpack_test.c
> @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = {
>  
>  kunit_test_suite(apparmor_policy_unpack_test_module);
>  
> +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591
> 

Following up to see if anything else is needed to get this merged.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] apparmor: test: add MODULE_DESCRIPTION()
  2024-05-30  1:21 [PATCH] apparmor: test: add MODULE_DESCRIPTION() Jeff Johnson
  2024-06-20 16:21 ` Jeff Johnson
@ 2024-06-25  8:26 ` John Johansen
  2024-07-11 17:45   ` Jeff Johnson
  1 sibling, 1 reply; 5+ messages in thread
From: John Johansen @ 2024-06-25  8:26 UTC (permalink / raw)
  To: Jeff Johnson, Paul Moore, James Morris, Serge E. Hallyn
  Cc: apparmor, linux-security-module, linux-kernel, kernel-janitors

On 5/29/24 18:21, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Acked-by: John Johansen <john.johansen@canonical.com>

I will pull this into my tree

> ---
>   security/apparmor/policy_unpack_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
> index 5c9bde25e56d..874fcf97794e 100644
> --- a/security/apparmor/policy_unpack_test.c
> +++ b/security/apparmor/policy_unpack_test.c
> @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = {
>   
>   kunit_test_suite(apparmor_policy_unpack_test_module);
>   
> +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack");
>   MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] apparmor: test: add MODULE_DESCRIPTION()
  2024-06-20 16:21 ` Jeff Johnson
@ 2024-06-25  8:26   ` John Johansen
  0 siblings, 0 replies; 5+ messages in thread
From: John Johansen @ 2024-06-25  8:26 UTC (permalink / raw)
  To: Jeff Johnson, Paul Moore, James Morris, Serge E. Hallyn
  Cc: apparmor, linux-security-module, linux-kernel, kernel-janitors

On 6/20/24 09:21, Jeff Johnson wrote:
> On 5/29/2024 6:21 PM, Jeff Johnson wrote:
>> Fix the 'make W=1' warning:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>   security/apparmor/policy_unpack_test.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
>> index 5c9bde25e56d..874fcf97794e 100644
>> --- a/security/apparmor/policy_unpack_test.c
>> +++ b/security/apparmor/policy_unpack_test.c
>> @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = {
>>   
>>   kunit_test_suite(apparmor_policy_unpack_test_module);
>>   
>> +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack");
>>   MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
>> change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591
>>
> 
> Following up to see if anything else is needed to get this merged.

sorry, just me catching up on my backlog


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] apparmor: test: add MODULE_DESCRIPTION()
  2024-06-25  8:26 ` John Johansen
@ 2024-07-11 17:45   ` Jeff Johnson
  0 siblings, 0 replies; 5+ messages in thread
From: Jeff Johnson @ 2024-07-11 17:45 UTC (permalink / raw)
  To: John Johansen, Paul Moore, James Morris, Serge E. Hallyn
  Cc: apparmor, linux-security-module, linux-kernel, kernel-janitors

On 6/25/24 01:26, John Johansen wrote:
> On 5/29/24 18:21, Jeff Johnson wrote:
>> Fix the 'make W=1' warning:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in 
>> security/apparmor/apparmor_policy_unpack_test.o
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> Acked-by: John Johansen <john.johansen@canonical.com>
> 
> I will pull this into my tree

I still don't see this in linux-next.
I'm hoping to have these warnings fixed tree-wide in 6.11.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-11 17:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30  1:21 [PATCH] apparmor: test: add MODULE_DESCRIPTION() Jeff Johnson
2024-06-20 16:21 ` Jeff Johnson
2024-06-25  8:26   ` John Johansen
2024-06-25  8:26 ` John Johansen
2024-07-11 17:45   ` Jeff Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).