From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287DE348445; Fri, 27 Feb 2026 18:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772216559; cv=none; b=i5qV+ZCBvdEcRRTszDgKEbPPROwdFWNr3D5J0fsCw7XBn949oKR7+uoosOUYv2j0kZHGwcTuC8KKp0Ox9qBujxyGyxuUFHiBjO6wSx4XKn3jagM/g0Omsv1hYTjKd8otuqrtXi4ExROhzC106SAl6bCve2sh5bEc1jtsLYi2qVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772216559; c=relaxed/simple; bh=jSW8xqvkSFWHqY7xXinynFM0z+oqvAK+4mvTfQzvAwU=; h=Message-ID:Subject:From:To:Cc:In-Reply-To:References:Content-Type: Date:MIME-Version; b=BUaf5wuBrpdhREZvMNisGHEX0wwzVCa2Zhpc3BkaN+9wOecvsXOY2m4zBostXBq6MsQtBUiXEGDKpskeSExIcw2nTyTg0ziZcNWk2SoAyNjs19NkJV6hW/CofwcvXUETHYCZ1fOwgLs3ZAJmZwHto8xSU+Ps1XmPrBbCBXEcRII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=W/J9uZLp; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="W/J9uZLp" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R9UfYW3273855; Fri, 27 Feb 2026 18:22:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=NDkVbv XOLq/UuXTo/484ujl50Ey1letRdpgIS+1Py0k=; b=W/J9uZLp0P1qVk4fPMFeB6 L+ICq3PWRlcgvAIUbaFqw8XfQzHz+JDEo+AC0tQm/1Dr2T5XJvsF1TDeNUAHYfbV Fq5lfAWj1XKLb6PrZJukyIeya5czSxqZv3jhjAszjYMbbb9XwrV7R3dKHoBq/OGE NYUzqTiDDfCInd8jovuwQoSfpKoTOONhf/FwW5HG4/DuUK2sJEfoTUIJ4bHtdVhs keNjoRA8rTpSczOFl7boZMbvQnp/Mov3E+ritGQ2QtpXturhY5qmZZXBs6rljq2C NLGURupu8utN+qZvBVKGTNBCxRRicdaF/LOU2crfSBgXmPCWgDQTM29YmmwEV2hw == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4cf472e6e3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 18:22:01 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61RHt9Ov013478; Fri, 27 Feb 2026 18:22:00 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cfqdykn14-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Feb 2026 18:21:59 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61RILxAq15532556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Feb 2026 18:21:59 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87CF35805C; Fri, 27 Feb 2026 18:21:59 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C110758058; Fri, 27 Feb 2026 18:21:57 +0000 (GMT) Received: from li-43857255-d5e6-4659-90f1-fc5cee4750ad.ibm.com (unknown [9.61.86.1]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Feb 2026 18:21:57 +0000 (GMT) Message-ID: <180f9f992ce862837058e7db943b117f2cc8a4ca.camel@linux.ibm.com> Subject: Re: [PATCH 1/2] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG From: Mimi Zohar To: Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Aaron Tomlin , Nicolas Schier In-Reply-To: <20260226-ima-ifdef-v1-1-8b9613edbbdb@weissschuh.net> References: <20260226-ima-ifdef-v1-0-8b9613edbbdb@weissschuh.net> <20260226-ima-ifdef-v1-1-8b9613edbbdb@weissschuh.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Fri, 27 Feb 2026 13:21:57 -0500 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: pFfTqbmMglxjGmMQbh6ifL8AVyznQOeB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDE2MSBTYWx0ZWRfX8RjHmLPn9Sxy 4I/RxNiX35lk4eFc4bbJm6PQRDE2mq09dc/szklGe7CNHj7sSszun3qWY/PejlkQP1FggxmTdQF lLySu8Ak1NxB+3CibRjTB7jcyjVTQ/eAIyc//4whOuL8MV1NQ5Ghi0h60XXKjbcCfmIIMEEZ2IZ bfqFivQmZEwpz/ubKgsGaeoMP3eInNSJiGZOK3+n6Pxv5J34YhV24OW651C9fR+uYfVv1bZBqYP H7BjOEAINMojziHR/mThcTI4rgdEupNd7j232CUV+aNO6G3MJWBnKHxwTU9NRsDMyORPBFrgImb yWGIxGJa9A8ryAN8y7N7jCfukFmRJCT7YtP3mxd3ETLbDyJx409GEGGB1a3ZxI6QKAt8crtDq/C oafpedlpfPWHrQeP7xpiuXRrzknOz83IxYYYtPCe/2G7LhUTWWbYVYqiXsDQLi1Wy3IFi4e6Z8C wexYaoSXHDNdvnCzRiQ== X-Authority-Analysis: v=2.4 cv=R7wO2NRX c=1 sm=1 tr=0 ts=69a1e0c9 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VTue-mJiAAAA:8 a=VnNF1IyMAAAA:8 a=j-LfP5YGAAAA:8 a=VwQbUJbxAAAA:8 a=Kxd9cklhb0fStvzIxPUA:9 a=QEXdDO2ut3YA:10 a=S9YjYK_EKPFYWS37g-LV:22 a=pci6KG57UX3UzFLC8IW4:22 X-Proofpoint-GUID: eRNUudb7ia1erSVYZK7al1Uq3mtQQXYL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_03,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1011 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602270161 On Thu, 2026-02-26 at 08:20 +0100, Thomas Wei=C3=9Fschuh wrote: > When configuration settings are disabled the guarded functions are > defined as empty stubs, so the check is unnecessary. >=20 > Signed-off-by: Thomas Wei=C3=9Fschuh > Reviewed-by: Mimi Zohar > Reviewed-by: Aaron Tomlin > Reviewed-by: Nicolas Schier > --- > security/integrity/ima/ima_efi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/security/integrity/ima/ima_efi.c b/security/integrity/ima/im= a_efi.c > index 138029bfcce1..a35dd166ad47 100644 > --- a/security/integrity/ima/ima_efi.c > +++ b/security/integrity/ima/ima_efi.c > @@ -68,10 +68,8 @@ static const char * const sb_arch_rules[] =3D { > const char * const *arch_get_ima_policy(void) > { > if (IS_ENABLED(CONFIG_IMA_ARCH_POLICY) && arch_ima_get_secureboot()) { > - if (IS_ENABLED(CONFIG_MODULE_SIG)) > - set_module_sig_enforced(); > - if (IS_ENABLED(CONFIG_KEXEC_SIG)) > - set_kexec_sig_enforced(); > + set_module_sig_enforced(); > + set_kexec_sig_enforced(); > return sb_arch_rules; > } > return NULL; Thanks, Thomas. With commit 63e8a44395a4 ("integrity: Make arch_ima_get_secureboot integrit= y- wide"), there was a merge conflict. After fixing the merge conflict, your patches are now queued in next-integrity. Mimi