From: Siddh Raman Pant <code@siddh.me>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: "David Howells" <dhowells@redhat.com>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"linux-security-modules" <linux-security-module@vger.kernel.org>,
"keyrings" <keyrings@vger.kernel.org>,
"linux-kernel-mentees"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree
Date: Sat, 23 Jul 2022 20:58:12 +0530 [thread overview]
Message-ID: <1822bac5c28.17c2e13a236951.2030393349322231875@siddh.me> (raw)
In-Reply-To: <YtwI/3/Qp3lSKuls@kroah.com>
On Sat, 23 Jul 2022 20:13:11 +0530 Greg KH <gregkh@linuxfoundation.org> wrote:
> You need to explain all of this in a changelog text. Don't say what you
> do, but say why you are doing it.
Okay, I will keep this in mind next time.
> > > And how was this tested?
> >
> > It compiles locally for me, and I used syzbot on this along with testing the
> > other `watch_queue_clear` patch, which generated no errors.
>
> How does the watch queue stuff relate to this keyctl logic?
>
> Again, be specific as to why you are doing things.
It doesn't relate, I just wanted to say that syzbot didn't crash too (I had
this change in the same branch as that patch for testing, and syzbot compiled
it successfully).
Sorry for the confusion.
Though now as James has pointed out, this patch isn't needed.
Apologies,
Siddh
next prev parent reply other threads:[~2022-07-23 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 13:50 [PATCH] keys/keyctl: Use kfree_rcu instead of kfree Siddh Raman Pant
2022-07-23 14:05 ` Greg KH
2022-07-23 14:35 ` Siddh Raman Pant
2022-07-23 14:43 ` Greg KH
2022-07-23 15:28 ` Siddh Raman Pant [this message]
2022-07-23 14:50 ` James Bottomley
2022-07-23 15:28 ` Siddh Raman Pant
2022-07-28 8:11 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822bac5c28.17c2e13a236951.2030393349322231875@siddh.me \
--to=code@siddh.me \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).