From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8DD4CCA48C for ; Sat, 23 Jul 2022 15:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233482AbiGWP2z (ORCPT ); Sat, 23 Jul 2022 11:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiGWP2y (ORCPT ); Sat, 23 Jul 2022 11:28:54 -0400 Received: from sender-of-o53.zoho.in (sender-of-o53.zoho.in [103.117.158.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD3CE6463; Sat, 23 Jul 2022 08:28:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658590104; cv=none; d=zohomail.in; s=zohoarc; b=SfXn29km/qJz/tyr1mEVbXFLg9lP11bJxbf9W4N664oeLlxSJXky7g+FNxTWxKTRXBnDKR5ip/ZuLKVkL1VQIKNNxkYuOzwrL0h6EPjABeKK6TpjaxaEgk9TJdZGerKYJYvuFYQRuCJqLBi7wBWX1uFR+FDG2Zj6ZZUMtUQkiDY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1658590104; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=c1lQAq9l2Vi8XJIR9+FZPadcoaYjnJn9vuGp/Q5uuoE=; b=a9OW8xI5fv1pW1A++gMs6sE9pCgr33942KvaplJ/Mu/4WGKFchUg3nwSmmfGw7lbXurGZZl5ZbOmq+5GbFcFWDenuxf4v93fIfIPtZv2E217/bxQ1TsCfjp0UWPbbBCuyFxGWSnbapDiCeHnUDlea0TS3kp+0pwiBPEJB5pWjVc= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658590104; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=c1lQAq9l2Vi8XJIR9+FZPadcoaYjnJn9vuGp/Q5uuoE=; b=lwAEDaBcqbpoTMrbx8xU+XgUjI5zEmh8ONCKOEoT+C37vmL0x1s1g+b0XpP6ZKON HYRGQOIj0oxNDYVUyds4QpDjYj6nJJbXnOYBnN6qXe5rsEWchmmtcbx8c15nrSOODxJ 0Y/pjeP6CJJ+5mNFcMbvSL4PDN/fWLPmqN7pEsy8= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1658590092355322.4350711864895; Sat, 23 Jul 2022 20:58:12 +0530 (IST) Date: Sat, 23 Jul 2022 20:58:12 +0530 From: Siddh Raman Pant To: "Greg KH" Cc: "David Howells" , "Jarkko Sakkinen" , "James Morris" , "Serge E. Hallyn" , "linux-security-modules" , "keyrings" , "linux-kernel-mentees" , "linux-kernel" Message-ID: <1822bac5c28.17c2e13a236951.2030393349322231875@siddh.me> In-Reply-To: References: <20220723135035.199188-1-code@siddh.me> <1822b7c129a.14411444236159.6380883938307880248@siddh.me> Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Precedence: bulk List-ID: On Sat, 23 Jul 2022 20:13:11 +0530 Greg KH wrote: > You need to explain all of this in a changelog text. Don't say what you > do, but say why you are doing it. Okay, I will keep this in mind next time. > > > And how was this tested? > > > > It compiles locally for me, and I used syzbot on this along with testing the > > other `watch_queue_clear` patch, which generated no errors. > > How does the watch queue stuff relate to this keyctl logic? > > Again, be specific as to why you are doing things. It doesn't relate, I just wanted to say that syzbot didn't crash too (I had this change in the same branch as that patch for testing, and syzbot compiled it successfully). Sorry for the confusion. Though now as James has pointed out, this patch isn't needed. Apologies, Siddh