From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm
Date: Mon, 25 Jun 2018 19:24:32 +0300 [thread overview]
Message-ID: <19b4282d625e04bb391f497419283a191bca610d.camel@linux.intel.com> (raw)
In-Reply-To: <20180624205202.6597-1-tomas.winkler@intel.com>
On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote:
> Fix tpm ptt initialization error:
> tpm tpm0: A TPM error (378) occurred get tpm pcr allocation.
>
> We cannot use go_idle cmd_ready commands via runtime_pm handles
> as with the introduction of localities this is no longer an optional
> feature, while runtime pm can be not enabled.
> Though cmd_ready/go_idle provides a power saving, it's also a part of
> TPM2 protocol and should be called explicitly.
> This patch exposes cmd_read/go_idle via tpm class ops and removes
> runtime pm support as it is not used by any driver.
>
> A new tpm transmit flag is added TPM_TRANSMIT_NESTED, which implies
> TPM_TRANSMIT_UNLOCKED and TPM_TRANSMIT_RAW. Both are needed to resolve
> tpm spaces and locality request recursive calls to tpm_transmit().
>
> New wrappers are added tpm_cmd_ready() and tpm_go_idle() to
> streamline tpm_try_transmit code.
>
> tpm_crb no longer needs own power saving functions and can drop using
> tpm_pm_suspend/resume.
>
> This patch cannot be really separated from the locality fix.
> Fixes: 888d867df441 (tpm: cmd_ready command can be issued only after granting
> locality)
>
> Cc: stable at vger.kernel.org
> Fixes: 888d867df441 (tpm: cmd_ready command can be issued only after granting
> locality)
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Please:
1. Remove NESTED.
2. Where you need call RAW | UNLOCKED.
3. Do not add __ prefix.
Should be simple changes to do.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-25 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 20:52 [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm Tomas Winkler
2018-06-25 16:24 ` Jarkko Sakkinen [this message]
2018-06-25 16:30 ` Jarkko Sakkinen
2018-06-26 21:15 ` Winkler, Tomas
2018-06-27 16:42 ` Jarkko Sakkinen
2018-06-27 21:13 ` Winkler, Tomas
2018-06-28 13:30 ` Jarkko Sakkinen
2018-06-28 15:02 ` Winkler, Tomas
2018-06-25 18:50 ` Winkler, Tomas
2018-06-26 8:22 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b4282d625e04bb391f497419283a191bca610d.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).