From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7E0C04EB8 for ; Thu, 6 Dec 2018 08:18:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A636C20989 for ; Thu, 6 Dec 2018 08:18:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A636C20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729038AbeLFIS1 (ORCPT ); Thu, 6 Dec 2018 03:18:27 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35420 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727575AbeLFIS1 (ORCPT ); Thu, 6 Dec 2018 03:18:27 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wB68936w177673 for ; Thu, 6 Dec 2018 03:18:26 -0500 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0b-001b2d01.pphosted.com with ESMTP id 2p6vyxqypw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Dec 2018 03:18:25 -0500 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Dec 2018 08:18:25 -0000 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 6 Dec 2018 08:18:22 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wB68ILjF18940126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 6 Dec 2018 08:18:21 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A208B205F; Thu, 6 Dec 2018 08:18:21 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDD99B2066; Thu, 6 Dec 2018 08:18:18 +0000 (GMT) Received: from [9.124.31.41] (unknown [9.124.31.41]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 6 Dec 2018 08:18:18 +0000 (GMT) Subject: Re: [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm To: Jarkko Sakkinen , Roberto Sassu Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com References: <20181204082138.24600-1-roberto.sassu@huawei.com> <20181204082138.24600-5-roberto.sassu@huawei.com> <20181204234024.GC1233@linux.intel.com> From: Nayna Jain Date: Thu, 6 Dec 2018 13:44:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20181204234024.GC1233@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18120608-2213-0000-0000-000003258CA2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010180; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01127715; UDB=6.00585774; IPR=6.00907847; MB=3.00024475; MTD=3.00000008; XFM=3.00000015; UTC=2018-12-06 08:18:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18120608-2214-0000-0000-00005C81385A Message-Id: <1e9f4b5a-c0fc-8be8-61f5-39166e948b01@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-06_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=914 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812060075 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 12/05/2018 05:10 AM, Jarkko Sakkinen wrote: > On Tue, Dec 04, 2018 at 09:21:35AM +0100, Roberto Sassu wrote: >> Currently the TPM driver allows other kernel subsystems to read only the >> SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and >> tpm2_pcr_read() to pass a tpm_digest structure, which contains the desired >> hash algorithm. Also, since commit 125a22105410 ("tpm: React correctly to >> RC_TESTING from TPM 2.0 self tests") removed the call to tpm2_pcr_read(), >> the new parameter is expected to be always not NULL. >> >> Due to the API change, IMA functions have been modified. >> >> Signed-off-by: Roberto Sassu >> Acked-by: Mimi Zohar > Reviewed-by: Jarkko Sakkinen > > Mimi, Nayna, can you help with testing this (because of the IMA change)? Sure, I will try to do by end of my day tomorrow, Thanks & Regards,     - Nayna > > /Jarkko >