* [PATCH 0/1] uapi: fix broken link in linux/capability.h
@ 2025-06-29 12:03 Ariel Otilibili
2025-06-29 12:03 ` [PATCH 1/1] " Ariel Otilibili
2025-07-02 10:00 ` [PATCH v2 0/1] " Ariel Otilibili
0 siblings, 2 replies; 10+ messages in thread
From: Ariel Otilibili @ 2025-06-29 12:03 UTC (permalink / raw)
To: linux-security-module; +Cc: Ariel Otilibili, Serge Hallyn, Andrew G . Morgan
Hello,
This patch fixes a broken link to the libcap library. Moreover it gives the full reference of its compliance with POSIX.
The README of libcap2 says it is based on Draft 15 [1]; but, as far as I could see, only copies of Draft 17 exist online [2, 3].
Your feedback is much appreciated,
Ariel
[1] https://git.kernel.org/pub/scm/libs/libcap/libcap.git/tree/README
[2] https://drive.google.com/file/d/16yTUA10JLyi6zKky9_KBu7P8FpZrprl3/view?usp=sharing
[3] https://simson.net/ref/1997/posix_1003.1e-990310.pdf
Ariel Otilibili (1):
uapi: fix broken link in linux/capability.h
include/uapi/linux/capability.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-06-29 12:03 [PATCH 0/1] uapi: fix broken link in linux/capability.h Ariel Otilibili
@ 2025-06-29 12:03 ` Ariel Otilibili
2025-06-29 14:27 ` Andrew G. Morgan
2025-07-02 2:05 ` Paul Moore
2025-07-02 10:00 ` [PATCH v2 0/1] " Ariel Otilibili
1 sibling, 2 replies; 10+ messages in thread
From: Ariel Otilibili @ 2025-06-29 12:03 UTC (permalink / raw)
To: linux-security-module; +Cc: Ariel Otilibili, Serge Hallyn, Andrew G . Morgan
The link to the libcap library is outdated:
> $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/"
>
> <html>
> <head><title>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</title></head>
> <body>
> <h1>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</h1><hr><pre><a href="../">../</a>
> </pre><hr></body>
> </html>
Instead, use a link to the libcap2 library:
> $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/"
>
> <html>
> <head><title>Index of /pub/linux/libs/security/linux-privs/libcap2/</title></head>
> <body>
> <h1>Index of /pub/linux/libs/security/linux-privs/libcap2/</h1><hr><pre><a href="../">../</a>
> <a href="old/">old/</a> 08-Nov-2007 06:34 -
> <a href="libcap-2.00.tar.gz">libcap-2.00.tar.gz</a> 11-Jan-2014 16:49 37K
> <a href="libcap-2.00.tar.sign">libcap-2.00.tar.sign</a> 11-Jan-2014 16:49 819
> [...]
> <a href="libcap-2.76.tar.sign">libcap-2.76.tar.sign</a> 13-Apr-2025 18:20 833
> <a href="libcap-2.76.tar.xz">libcap-2.76.tar.xz</a> 13-Apr-2025 18:20 195K
> <a href="sha256sums.asc">sha256sums.asc</a> 13-Apr-2025 18:25 14K
> </pre><hr></body>
> </html>
As well, give the complete reference of the POSIX compliance.
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Andrew G. Morgan <morgan@kernel.org>
---
include/uapi/linux/capability.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
index 2e21b5594f81..ea5a0899ecf0 100644
--- a/include/uapi/linux/capability.h
+++ b/include/uapi/linux/capability.h
@@ -6,9 +6,10 @@
* Alexander Kjeldaas <astor@guardian.no>
* with help from Aleph1, Roland Buresund and Andrew Main.
*
- * See here for the libcap library ("POSIX draft" compliance):
+ * See here for the libcap2 library (compliant with Section 25 of
+ * the withdrawn POSIX 1003.1e Draft 17):
*
- * ftp://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/
+ * https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/
*/
#ifndef _UAPI_LINUX_CAPABILITY_H
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-06-29 12:03 ` [PATCH 1/1] " Ariel Otilibili
@ 2025-06-29 14:27 ` Andrew G. Morgan
2025-06-29 23:16 ` Ariel Otilibili-Anieli
2025-07-02 2:05 ` Paul Moore
1 sibling, 1 reply; 10+ messages in thread
From: Andrew G. Morgan @ 2025-06-29 14:27 UTC (permalink / raw)
To: Ariel Otilibili; +Cc: linux-security-module, Serge Hallyn
Thanks for noticing that!
Acked-by: Andrew G. Morgan <morgan@kernel.org>
Cheers
Andrew
On Sun, Jun 29, 2025 at 5:03 AM Ariel Otilibili
<ariel.otilibili-anieli@eurecom.fr> wrote:
>
> The link to the libcap library is outdated:
>
> > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/"
> >
> > <html>
> > <head><title>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</title></head>
> > <body>
> > <h1>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</h1><hr><pre><a href="../">../</a>
> > </pre><hr></body>
> > </html>
>
> Instead, use a link to the libcap2 library:
>
> > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/"
> >
> > <html>
> > <head><title>Index of /pub/linux/libs/security/linux-privs/libcap2/</title></head>
> > <body>
> > <h1>Index of /pub/linux/libs/security/linux-privs/libcap2/</h1><hr><pre><a href="../">../</a>
> > <a href="old/">old/</a> 08-Nov-2007 06:34 -
> > <a href="libcap-2.00.tar.gz">libcap-2.00.tar.gz</a> 11-Jan-2014 16:49 37K
> > <a href="libcap-2.00.tar.sign">libcap-2.00.tar.sign</a> 11-Jan-2014 16:49 819
> > [...]
> > <a href="libcap-2.76.tar.sign">libcap-2.76.tar.sign</a> 13-Apr-2025 18:20 833
> > <a href="libcap-2.76.tar.xz">libcap-2.76.tar.xz</a> 13-Apr-2025 18:20 195K
> > <a href="sha256sums.asc">sha256sums.asc</a> 13-Apr-2025 18:25 14K
> > </pre><hr></body>
> > </html>
>
> As well, give the complete reference of the POSIX compliance.
>
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> ---
> Cc: Serge Hallyn <serge@hallyn.com>
> Cc: Andrew G. Morgan <morgan@kernel.org>
> ---
> include/uapi/linux/capability.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 2e21b5594f81..ea5a0899ecf0 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -6,9 +6,10 @@
> * Alexander Kjeldaas <astor@guardian.no>
> * with help from Aleph1, Roland Buresund and Andrew Main.
> *
> - * See here for the libcap library ("POSIX draft" compliance):
> + * See here for the libcap2 library (compliant with Section 25 of
> + * the withdrawn POSIX 1003.1e Draft 17):
> *
> - * ftp://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/
> + * https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/
> */
>
> #ifndef _UAPI_LINUX_CAPABILITY_H
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-06-29 14:27 ` Andrew G. Morgan
@ 2025-06-29 23:16 ` Ariel Otilibili-Anieli
0 siblings, 0 replies; 10+ messages in thread
From: Ariel Otilibili-Anieli @ 2025-06-29 23:16 UTC (permalink / raw)
To: Andrew G. Morgan; +Cc: linux-security-module, Serge Hallyn
On Sunday, June 29, 2025 16:27 CEST, "Andrew G. Morgan" <morgan@kernel.org> wrote:
> Thanks for noticing that!
Your welcome, Andrew!
>
> Acked-by: Andrew G. Morgan <morgan@kernel.org>
Much appreciated,
Ariel
>
> Cheers
>
> Andrew
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-06-29 12:03 ` [PATCH 1/1] " Ariel Otilibili
2025-06-29 14:27 ` Andrew G. Morgan
@ 2025-07-02 2:05 ` Paul Moore
2025-07-02 2:20 ` Serge E. Hallyn
1 sibling, 1 reply; 10+ messages in thread
From: Paul Moore @ 2025-07-02 2:05 UTC (permalink / raw)
To: Ariel Otilibili, linux-security-module
Cc: Ariel Otilibili, Serge Hallyn, Andrew G . Morgan
On Jun 29, 2025 Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:
>
> The link to the libcap library is outdated:
>
> > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/"
> >
> > <html>
> > <head><title>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</title></head>
> > <body>
> > <h1>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</h1><hr><pre><a href="../">../</a>
> > </pre><hr></body>
> > </html>
>
> Instead, use a link to the libcap2 library:
>
> > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/"
> >
> > <html>
> > <head><title>Index of /pub/linux/libs/security/linux-privs/libcap2/</title></head>
> > <body>
> > <h1>Index of /pub/linux/libs/security/linux-privs/libcap2/</h1><hr><pre><a href="../">../</a>
> > <a href="old/">old/</a> 08-Nov-2007 06:34 -
> > <a href="libcap-2.00.tar.gz">libcap-2.00.tar.gz</a> 11-Jan-2014 16:49 37K
> > <a href="libcap-2.00.tar.sign">libcap-2.00.tar.sign</a> 11-Jan-2014 16:49 819
> > [...]
> > <a href="libcap-2.76.tar.sign">libcap-2.76.tar.sign</a> 13-Apr-2025 18:20 833
> > <a href="libcap-2.76.tar.xz">libcap-2.76.tar.xz</a> 13-Apr-2025 18:20 195K
> > <a href="sha256sums.asc">sha256sums.asc</a> 13-Apr-2025 18:25 14K
> > </pre><hr></body>
> > </html>
>
> As well, give the complete reference of the POSIX compliance.
>
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> Acked-by: Andrew G. Morgan <morgan@kernel.org>
> ---
> Cc: Serge Hallyn <serge@hallyn.com>
> Cc: Andrew G. Morgan <morgan@kernel.org>
> ---
> include/uapi/linux/capability.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
My personal preference would be for a commit description that doesn't
wrap when running 'git log' on a 80 char wide terminal, but ultimately
that is Serge's call to make. Otherwise, the updated URL looks good to
me.
Reviewed-by: Paul Moore <paul@paul-moore.com>
--
paul-moore.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-07-02 2:05 ` Paul Moore
@ 2025-07-02 2:20 ` Serge E. Hallyn
2025-07-02 10:05 ` Ariel Otilibili-Anieli
0 siblings, 1 reply; 10+ messages in thread
From: Serge E. Hallyn @ 2025-07-02 2:20 UTC (permalink / raw)
To: Paul Moore
Cc: Ariel Otilibili, linux-security-module, Serge Hallyn,
Andrew G . Morgan
On Tue, Jul 01, 2025 at 10:05:45PM -0400, Paul Moore wrote:
> On Jun 29, 2025 Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:
> >
> > The link to the libcap library is outdated:
> >
> > > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/"
> > >
> > > <html>
> > > <head><title>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</title></head>
> > > <body>
> > > <h1>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</h1><hr><pre><a href="../">../</a>
> > > </pre><hr></body>
> > > </html>
> >
> > Instead, use a link to the libcap2 library:
> >
> > > $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/"
> > >
> > > <html>
> > > <head><title>Index of /pub/linux/libs/security/linux-privs/libcap2/</title></head>
> > > <body>
> > > <h1>Index of /pub/linux/libs/security/linux-privs/libcap2/</h1><hr><pre><a href="../">../</a>
> > > <a href="old/">old/</a> 08-Nov-2007 06:34 -
> > > <a href="libcap-2.00.tar.gz">libcap-2.00.tar.gz</a> 11-Jan-2014 16:49 37K
> > > <a href="libcap-2.00.tar.sign">libcap-2.00.tar.sign</a> 11-Jan-2014 16:49 819
> > > [...]
> > > <a href="libcap-2.76.tar.sign">libcap-2.76.tar.sign</a> 13-Apr-2025 18:20 833
> > > <a href="libcap-2.76.tar.xz">libcap-2.76.tar.xz</a> 13-Apr-2025 18:20 195K
> > > <a href="sha256sums.asc">sha256sums.asc</a> 13-Apr-2025 18:25 14K
> > > </pre><hr></body>
> > > </html>
> >
> > As well, give the complete reference of the POSIX compliance.
> >
> > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> > Acked-by: Andrew G. Morgan <morgan@kernel.org>
> > ---
> > Cc: Serge Hallyn <serge@hallyn.com>
> > Cc: Andrew G. Morgan <morgan@kernel.org>
> > ---
> > include/uapi/linux/capability.h | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> My personal preference would be for a commit description that doesn't
> wrap when running 'git log' on a 80 char wide terminal, but ultimately
Agreed. Would you mind updating that, and then I'll pull it in?
thanks,
-serge
> that is Serge's call to make. Otherwise, the updated URL looks good to
> me.
>
> Reviewed-by: Paul Moore <paul@paul-moore.com>
>
> --
> paul-moore.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 0/1] uapi: fix broken link in linux/capability.h
2025-06-29 12:03 [PATCH 0/1] uapi: fix broken link in linux/capability.h Ariel Otilibili
2025-06-29 12:03 ` [PATCH 1/1] " Ariel Otilibili
@ 2025-07-02 10:00 ` Ariel Otilibili
2025-07-02 10:00 ` [PATCH v2 1/1] " Ariel Otilibili
1 sibling, 1 reply; 10+ messages in thread
From: Ariel Otilibili @ 2025-07-02 10:00 UTC (permalink / raw)
To: linux-security-module
Cc: Andrew G . Morgan, Paul Moore, Serge Hallyn, Ariel Otilibili
Hello,
This patch fixes a broken link to the libcap library. The old link is outdated:
> $ curl "https://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/"
>
> <html>
> <head><title>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</title></head>
> <body>
> <h1>Index of /pub/linux/libs/security/linux-privs/kernel-2.6/</h1><hr><pre><a href="../">../</a>
> </pre><hr></body>
> </html>
Moreover the patch gives the full reference of the compliance with POSIX.
The README of libcap2 says it is based on Draft 15 [1]; but, as far as I could see, only copies of Draft 17 exist online [2, 3].
Your feedback is much appreciated,
Ariel
[1] https://git.kernel.org/pub/scm/libs/libcap/libcap.git/tree/README
[2] https://drive.google.com/file/d/16yTUA10JLyi6zKky9_KBu7P8FpZrprl3/view?usp=sharing
[3] https://simson.net/ref/1997/posix_1003.1e-990310.pdf
---
v2:
* reworded commit log (Paul Moore)
* reworded cover letter
v1 (https://lore.kernel.org/all/20250629120301.1702897-1-ariel.otilibili-anieli@eurecom.fr)
Ariel Otilibili (1):
uapi: fix broken link in linux/capability.h
include/uapi/linux/capability.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/1] uapi: fix broken link in linux/capability.h
2025-07-02 10:00 ` [PATCH v2 0/1] " Ariel Otilibili
@ 2025-07-02 10:00 ` Ariel Otilibili
0 siblings, 0 replies; 10+ messages in thread
From: Ariel Otilibili @ 2025-07-02 10:00 UTC (permalink / raw)
To: linux-security-module
Cc: Andrew G . Morgan, Paul Moore, Serge Hallyn, Ariel Otilibili
The link to the libcap library is outdated. Instead, use a link to the
libcap2 library.
As well, give the complete reference of the POSIX compliance.
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
Acked-by: Andrew G. Morgan <morgan@kernel.org>
Reviewed-by: Paul Moore <paul@paul-moore.com>
---
include/uapi/linux/capability.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
index 2e21b5594f81..ea5a0899ecf0 100644
--- a/include/uapi/linux/capability.h
+++ b/include/uapi/linux/capability.h
@@ -6,9 +6,10 @@
* Alexander Kjeldaas <astor@guardian.no>
* with help from Aleph1, Roland Buresund and Andrew Main.
*
- * See here for the libcap library ("POSIX draft" compliance):
+ * See here for the libcap2 library (compliant with Section 25 of
+ * the withdrawn POSIX 1003.1e Draft 17):
*
- * ftp://www.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/
+ * https://www.kernel.org/pub/linux/libs/security/linux-privs/libcap2/
*/
#ifndef _UAPI_LINUX_CAPABILITY_H
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-07-02 2:20 ` Serge E. Hallyn
@ 2025-07-02 10:05 ` Ariel Otilibili-Anieli
2025-07-05 0:25 ` sergeh
0 siblings, 1 reply; 10+ messages in thread
From: Ariel Otilibili-Anieli @ 2025-07-02 10:05 UTC (permalink / raw)
To: Serge E. Hallyn; +Cc: Paul Moore, linux-security-module, Andrew G . Morgan
Hi Serge, hi Paul,
On Wednesday, July 02, 2025 04:20 CEST, "Serge E. Hallyn" <serge@hallyn.com> wrote:
> On Tue, Jul 01, 2025 at 10:05:45PM -0400, Paul Moore wrote:
> > On Jun 29, 2025 Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:
> > > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> > > Acked-by: Andrew G. Morgan <morgan@kernel.org>
> >
> > My personal preference would be for a commit description that doesn't
> > wrap when running 'git log' on a 80 char wide terminal, but ultimately
>
> Agreed. Would you mind updating that, and then I'll pull it in?
Sure, there you are: https://lore.kernel.org/all/20250702100021.1849243-2-ariel.otilibili-anieli@eurecom.fr/
>
> thanks,
> -serge
>
> > that is Serge's call to make. Otherwise, the updated URL looks good to
> > me.
> >
> > Reviewed-by: Paul Moore <paul@paul-moore.com>
Thanks for your feedback,
Ariel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] uapi: fix broken link in linux/capability.h
2025-07-02 10:05 ` Ariel Otilibili-Anieli
@ 2025-07-05 0:25 ` sergeh
0 siblings, 0 replies; 10+ messages in thread
From: sergeh @ 2025-07-05 0:25 UTC (permalink / raw)
To: Ariel Otilibili-Anieli
Cc: Serge E. Hallyn, Paul Moore, linux-security-module,
Andrew G . Morgan
On Wed, Jul 02, 2025 at 12:05:36PM +0200, Ariel Otilibili-Anieli wrote:
> Hi Serge, hi Paul,
>
> On Wednesday, July 02, 2025 04:20 CEST, "Serge E. Hallyn" <serge@hallyn.com> wrote:
>
> > On Tue, Jul 01, 2025 at 10:05:45PM -0400, Paul Moore wrote:
> > > On Jun 29, 2025 Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:
> > > > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> > > > Acked-by: Andrew G. Morgan <morgan@kernel.org>
> > >
> > > My personal preference would be for a commit description that doesn't
> > > wrap when running 'git log' on a 80 char wide terminal, but ultimately
> >
> > Agreed. Would you mind updating that, and then I'll pull it in?
>
> Sure, there you are: https://lore.kernel.org/all/20250702100021.1849243-2-ariel.otilibili-anieli@eurecom.fr/
> >
> > thanks,
> > -serge
> >
> > > that is Serge's call to make. Otherwise, the updated URL looks good to
> > > me.
> > >
> > > Reviewed-by: Paul Moore <paul@paul-moore.com>
>
> Thanks for your feedback,
> Ariel
Thanks - applied.
-serge
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-07-05 0:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-29 12:03 [PATCH 0/1] uapi: fix broken link in linux/capability.h Ariel Otilibili
2025-06-29 12:03 ` [PATCH 1/1] " Ariel Otilibili
2025-06-29 14:27 ` Andrew G. Morgan
2025-06-29 23:16 ` Ariel Otilibili-Anieli
2025-07-02 2:05 ` Paul Moore
2025-07-02 2:20 ` Serge E. Hallyn
2025-07-02 10:05 ` Ariel Otilibili-Anieli
2025-07-05 0:25 ` sergeh
2025-07-02 10:00 ` [PATCH v2 0/1] " Ariel Otilibili
2025-07-02 10:00 ` [PATCH v2 1/1] " Ariel Otilibili
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).