From: ebiggers3@gmail.com (Eric Biggers)
To: linux-security-module@vger.kernel.org
Subject: security/keys: add CONFIG_KEYS_COMPAT to Kconfig
Date: Wed, 29 Mar 2017 12:20:02 -0700 [thread overview]
Message-ID: <20170329192002.GA29310@gmail.com> (raw)
In-Reply-To: <1486674698-67190-1-git-send-email-bilal.amarni@gmail.com>
On Thu, 9 Feb 2017 22:11:38 +0100, Bilal Amarni wrote:
> CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for
> several 64-bit architectures : arm64, mips, parisc, tile.
>
> At the moment and for those architectures, calling in 32-bit userspace the
> keyctl syscall would return an ENOSYS error.
>
> This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to
> make sure the compatibility wrapper is registered by default for any 64-bit
> architecture as long as it is configured with CONFIG_COMPAT.
David, where can I find the git branch this patch was applied to? I don't see
it anywhere in security-keys or linux-security.
I recently added KEYS_COMPAT to arm64 (5c2a625937ba); that should be reverted
after this patch.
Also, I'd like to submit a follow-on patch that removes KEYS_COMPAT and simply
uses COMPAT.
And the parisc architecture doesn't use compat_sys_keyctl() in its compat
syscall table, so that should be fixed too (though that's not a new bug).
- Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2017-03-29 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1486674698-67190-1-git-send-email-bilal.amarni@gmail.com>
2017-03-29 19:20 ` Eric Biggers [this message]
2017-06-03 2:43 ` security/keys: add CONFIG_KEYS_COMPAT to Kconfig Eric Biggers
2017-06-03 8:04 ` David Howells
2017-06-05 3:34 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329192002.GA29310@gmail.com \
--to=ebiggers3@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).