From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Wed, 14 Jun 2017 13:40:02 +0300 Subject: [PATCH] apparmor: fix error code in aafs_create() Message-ID: <20170614104002.GL29394@elgon.mountain> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org We accidentally return ERR_PTR(0) if lookup_one_len() fails. The caller is expecting error pointers so it likely causes problems later on. For example, on one path I saw it triggered an AA_BUG(). Fixes: a481f4d91783 ("apparmor: add custom apparmorfs that will be used by policy namespace files") Signed-off-by: Dan Carpenter diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index 853c2ec8e0c9..2caeb748070c 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -248,8 +248,10 @@ static struct dentry *aafs_create(const char *name, umode_t mode, inode_lock(dir); dentry = lookup_one_len(name, parent, strlen(name)); - if (IS_ERR(dentry)) + if (IS_ERR(dentry)) { + error = PTR_ERR(dentry); goto fail_lock; + } if (d_really_is_positive(dentry)) { error = -EEXIST; -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html