linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: serge@hallyn.com (Serge E. Hallyn)
To: linux-security-module@vger.kernel.org
Subject: [PATCH V3 04/10] capabilities: use root_priveleged inline to clarify logic
Date: Thu, 31 Aug 2017 09:49:43 -0500	[thread overview]
Message-ID: <20170831144943.GA12295@mail.hallyn.com> (raw)
In-Reply-To: <20170828120307.GN24692@madcap2.tricolour.ca>

Quoting Richard Guy Briggs (rgb at redhat.com):
> On 2017-08-25 15:58, James Morris wrote:
> > On Wed, 23 Aug 2017, Richard Guy Briggs wrote:
> > 
> > > Introduce inline root_privileged() to make use of SECURE_NONROOT
> > > easier to read.
> > > 
> > > Suggested-by: Serge Hallyn <serge@hallyn.com>
> > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > ---
> > >  security/commoncap.c |    9 +++++----
> > >  1 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > Acked-by: James Morris <james.l.morris@oracle.com>
> 
> Does anyone have the appetite to move this helper function to
> include/linux/securebits.h along with issecure() to make it more widely
> available?

If it's going to have wider scope, then it probably needs to be
renamed to be unambiguous in any context.  root_implies_privilege
or uid0_is_privileged maybe?   Maybe root_privileged() is ok...
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-08-31 14:49 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 10:12 [PATCH V3 00/10] capabilities: do not audit log BPRM_FCAPS on set*id Richard Guy Briggs
2017-08-23 10:12 ` [PATCH V3 01/10] capabilities: factor out cap_bprm_set_creds privileged root Richard Guy Briggs
2017-08-24 15:42   ` Serge E. Hallyn
2017-08-25  5:55   ` James Morris
2017-08-25 10:49     ` Richard Guy Briggs
2017-08-23 10:12 ` [PATCH V3 02/10] capabilities: intuitive names for cap gain status Richard Guy Briggs
2017-08-24 16:03   ` Serge E. Hallyn
2017-08-24 16:19     ` Richard Guy Briggs
2017-08-24 16:37       ` Serge E. Hallyn
2017-08-24 19:06         ` Kees Cook
2017-08-24 21:17           ` Paul Moore
2017-08-28  9:19           ` Richard Guy Briggs
2017-08-28 11:08             ` Richard Guy Briggs
2017-09-01 10:18               ` Richard Guy Briggs
2017-09-02  5:37                 ` Serge E. Hallyn
2017-09-04  6:57                   ` Richard Guy Briggs
2017-09-05  6:45                     ` Richard Guy Briggs
2017-08-25  5:56   ` James Morris
2017-08-25 15:08   ` Andy Lutomirski
2017-08-25 18:47     ` Serge E. Hallyn
2017-08-23 10:12 ` [PATCH V3 03/10] capabilities: rename has_cap to has_fcap Richard Guy Briggs
2017-08-24 16:10   ` Serge E. Hallyn
2017-08-25  5:56   ` James Morris
2017-08-23 10:12 ` [PATCH V3 04/10] capabilities: use root_priveleged inline to clarify logic Richard Guy Briggs
2017-08-24 16:14   ` Serge E. Hallyn
2017-08-25  5:58   ` James Morris
2017-08-28 12:03     ` Richard Guy Briggs
2017-08-31 14:49       ` Serge E. Hallyn [this message]
2017-08-23 10:12 ` [PATCH V3 05/10] capabilities: use intuitive names for id changes Richard Guy Briggs
2017-08-24 16:17   ` Serge E. Hallyn
2017-08-25  5:59   ` James Morris
2017-08-25 15:06   ` Andy Lutomirski
2017-08-25 18:51     ` Serge E. Hallyn
2017-08-25 19:45       ` Andy Lutomirski
2017-08-25 20:06         ` Serge E. Hallyn
2017-08-28  1:32           ` James Morris
2017-08-28  9:12           ` Richard Guy Briggs
2017-08-28 20:12             ` Andy Lutomirski
2017-08-23 10:12 ` [PATCH V3 06/10] capabilities: move audit log decision to function Richard Guy Briggs
2017-08-24 16:18   ` Serge E. Hallyn
2017-08-25  6:01   ` James Morris
2017-08-23 10:12 ` [PATCH V3 07/10] capabilities: remove a layer of conditional logic Richard Guy Briggs
2017-08-24 16:20   ` Serge E. Hallyn
2017-08-25  5:47   ` James Morris
2017-08-25 15:11   ` Andy Lutomirski
2017-08-25 18:53     ` Serge E. Hallyn
2017-08-23 10:12 ` [PATCH V3 08/10] capabilities: invert logic for clarity Richard Guy Briggs
2017-08-24 16:23   ` Serge E. Hallyn
2017-08-25  5:47   ` James Morris
2017-08-23 10:13 ` [PATCH V3 09/10] capabilities: fix logic for effective root or real root Richard Guy Briggs
2017-08-24 16:29   ` Serge E. Hallyn
2017-08-24 16:44     ` Richard Guy Briggs
2017-08-24 16:47       ` Serge E. Hallyn
2017-08-25  5:48   ` James Morris
2017-08-23 10:13 ` [PATCH V3 10/10] capabilities: audit log other surprising conditions Richard Guy Briggs
2017-08-24 16:35   ` Serge E. Hallyn
2017-08-25  5:50   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831144943.GA12295@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).