* [PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 15:38 Colin King
2017-10-16 22:42 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-14 15:38 UTC (permalink / raw)
To: linux-security-module
From: Colin Ian King <colin.king@canonical.com>
Variables slots_used and max_chain_len are being initialized to zero
twice. Remove the second set of initializations in the for loop.
Cleans up the clang warnings:
Value stored to 'slots_used' is never read
Value stored to 'max_chain_len' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
security/selinux/ss/hashtab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
index bef7577d1270..e0443f4afea5 100644
--- a/security/selinux/ss/hashtab.c
+++ b/security/selinux/ss/hashtab.c
@@ -150,7 +150,7 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
slots_used = 0;
max_chain_len = 0;
- for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
+ for (i = 0; i < h->size; i++) {
cur = h->htable[i];
if (cur) {
slots_used++;
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain_len
2017-10-14 15:38 [PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain_len Colin King
@ 2017-10-16 22:42 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2017-10-16 22:42 UTC (permalink / raw)
To: linux-security-module
On Sat, Oct 14, 2017 at 11:38 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the second set of initializations in the for loop.
> Cleans up the clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> security/selinux/ss/hashtab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Also merged, thanks.
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
> index bef7577d1270..e0443f4afea5 100644
> --- a/security/selinux/ss/hashtab.c
> +++ b/security/selinux/ss/hashtab.c
> @@ -150,7 +150,7 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
>
> slots_used = 0;
> max_chain_len = 0;
> - for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> + for (i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
> slots_used++;
> --
> 2.14.1
--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-14 15:38 [PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain_len Colin King
2017-10-16 22:42 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).