linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API
Date: Tue, 24 Oct 2017 09:55:26 -0600	[thread overview]
Message-ID: <20171024155526.GA32250@obsidianresearch.com> (raw)
In-Reply-To: <CANc+2y4TbkfPT3d_sBd0MbE7ZJ4F7Sfsfvdv9V6=63=tRpWn4A@mail.gmail.com>

On Tue, Oct 24, 2017 at 09:21:15PM +0530, PrasannaKumar Muralidharan wrote:

> Please check the RFC [1]. It does use chip id. The rfc has issues and
> has to be fixed but still there could be users of the API.
> 
> 1. https://www.spinics.net/lists/linux-crypto/msg28282.html

That patch isn't safe at all. You need to store a kref to th chip in
the hwrng, not parse a string.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-10-24 15:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 12:38 [PATCH] tpm: remove chip_num parameter from in-kernel API Jarkko Sakkinen
2017-10-23 14:07 ` [tpmdd-devel] " Stefan Berger
2017-10-23 16:31   ` Jason Gunthorpe
2017-10-24 15:44     ` Jarkko Sakkinen
2017-10-24 15:51       ` PrasannaKumar Muralidharan
2017-10-24 15:55         ` Jason Gunthorpe [this message]
2017-10-24 16:07           ` PrasannaKumar Muralidharan
2017-10-24 16:11             ` Jason Gunthorpe
2017-10-24 16:14               ` PrasannaKumar Muralidharan
2017-10-24 17:46                 ` Jason Gunthorpe
2017-10-24 17:56                   ` PrasannaKumar Muralidharan
2017-10-24 17:02               ` Dmitry Torokhov
2017-10-24 17:37                 ` Jason Gunthorpe
2017-10-24 17:44                   ` PrasannaKumar Muralidharan
2017-10-24 18:04                   ` Dmitry Torokhov
2017-10-24 18:15                 ` Jarkko Sakkinen
2017-10-24 18:40                   ` Peter Huewe
2017-10-24 16:23         ` Jarkko Sakkinen
2017-10-24 16:35           ` PrasannaKumar Muralidharan
2017-10-24 18:22             ` Jarkko Sakkinen
2017-10-25 14:51               ` PrasannaKumar Muralidharan
2017-10-25 19:11                 ` Jarkko Sakkinen
2017-10-26 16:23                   ` PrasannaKumar Muralidharan
2017-10-24 14:04   ` Jarkko Sakkinen
2017-10-24 18:52 ` Jason Gunthorpe
2017-10-24 22:27   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024155526.GA32250@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).