From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c
Date: Wed, 25 Oct 2017 15:18:48 +0200 [thread overview]
Message-ID: <20171025131848.3il7j5rw7nt7e2l6@linux.intel.com> (raw)
In-Reply-To: <CA+zpnLft_o-c2cRxtUEoAPbYiiLzmLqAPYwrkFDdVoyk5t6Zfw@mail.gmail.com>
On Wed, Oct 25, 2017 at 10:43:10AM +0200, Thiebaud Weksteen wrote:
> On Wed, Oct 25, 2017 at 12:21 AM, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> > I noticed when making slides for KS that the naming for event log stuff
> > that the naming is so broken that it is hard to understand the code.
> > Here it really would make sense to have a patch set just to clean up the
> > cruft.
>
> Agreed and happy to help.
That would be great! Thank you.
> > Random examples of more senseful naming:
> >
> > * tpm2_bios_measurements_start() should be rather something like
> > tpm_eventlog_seq_agile_start().
> > * tpm_bios_measurements_start() should be rather something like
> > tpm_eventlog_seq_sha1_start().
> >
> > Corresponding structs would be tpm_eventlog_agile_seq_ops and
> > tpm_eventlog_sha1_seq_ops.
> >
> > Finally, I would place the file operations, being so complicated, in
> > separate files:
> >
> > * tpm_eventlog_seq_sha1.c
> > * tpm_eventlog_seq_eventlog.c
>
> I assume you meant tpm_eventlog_seq_agile.c ?
Yes.
> >
> > And move all the management code that is right now illogically located
> > in tpm1_eventlog.c to tpm_eventlog.c that would be the entry point for
> > the event log.
> >
> > The code is laid out so badly right now that I have really hard time
> > understanding it if I haven't looked at it within last couple of weeks.
> > It's really a trainwreck at the moment. We must clean up it up fast.
> >
> > Getting this done will help me to review patches to this area faster
> > so it would be a benefit for everyone. The current structure makes every
> > event log patch a pain to review.
>
> Since this may conflict with the last patch set I sent, are you happy
> for me to base this new set on tpmdd/master?
What about this: you do an updated version of your patch set that
includes these clean ups?
PS. Sorry for slowness with your patches. I've just had a lot of stuff
going on lately. They are 2nd in my priority queue right after
CVE-2017-15361.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-25 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 22:21 Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c Jarkko Sakkinen
2017-10-25 8:43 ` Thiebaud Weksteen
2017-10-25 13:18 ` Jarkko Sakkinen [this message]
2017-10-26 14:14 ` Jarkko Sakkinen
2017-10-27 9:13 ` Thiebaud Weksteen
2017-10-30 18:34 ` Nayna Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025131848.3il7j5rw7nt7e2l6@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).