linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jgg@ziepe.ca (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data
Date: Mon, 1 Jan 2018 21:40:44 -0700	[thread overview]
Message-ID: <20180102044044.GA29208@ziepe.ca> (raw)
In-Reply-To: <1514865944-95086-2-git-send-email-azhar.shaikh@intel.com>

On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote:

> -	return tpm_chip_register(chip);
> +	rc = tpm_chip_register(chip);
> +	if (rc && is_bsw())
> +		iounmap(priv->ilb_base_addr);
> +
> +	return rc;
>  out_err:
>  	tpm_tis_remove(chip);
> +	if (is_bsw())
> +		iounmap(priv->ilb_base_addr);
> +
>  	return rc;
>  }

I thought you were resending this to fix the above, why is is it still
wonky?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-02  4:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02  4:05 [PATCH v8 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Azhar Shaikh
2018-01-02  4:05 ` [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data Azhar Shaikh
2018-01-02  4:40   ` Jason Gunthorpe [this message]
2018-01-02  5:01     ` Shaikh, Azhar
2018-01-02  5:31       ` Shaikh, Azhar
2018-01-02 14:57         ` Jason Gunthorpe
2018-01-02  4:05 ` [PATCH v8 2/2] tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd() Azhar Shaikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102044044.GA29208@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).