From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.
Date: Tue, 6 Mar 2018 10:02:15 +0200 [thread overview]
Message-ID: <20180306080159.GC3624@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9422E568@hasmsx108.ger.corp.intel.com>
On Mon, Mar 05, 2018 at 06:04:56PM +0000, Winkler, Tomas wrote:
> >
> > On Mon, Mar 05, 2018 at 01:09:09PM +0000, Winkler, Tomas wrote:
> > > > enum tpm_duration {
> > > > TPM_DURATION_DEFAULT = 2000,
> > > > TPM_DURATION_LONG = 300000,
> > > > };
> > > >
> > > How is this aligned with the spec PTP spec?
> >
> > For TPM 2.0 that spec only partially defines durations for CCs and thus our
> > look up table is already kind "flakky". In a sense that the default duration is
> > upper limit for spec defined durations.
>
> The timeouts for LONG and MEDIUM is defined by the PTP spec, we need to maintain those as those effect the system.
> The UNDEFINED and LONG LONG is the implementation choice we driver from empirical data we have so far.
Where can be get this empirical data?
You are not only adding 30s delay but also turning the 2s delay to 12s
delay.
IMHO we could very well use PTP LONG for all commands as the timeout.
Why that would not work?
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-06 8:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:12 [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Tomas Winkler
2018-03-04 12:12 ` [PATCH 2/3] tpm: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-03-05 13:02 ` Jarkko Sakkinen
2018-03-04 12:12 ` [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Tomas Winkler
2018-03-05 13:03 ` Jarkko Sakkinen
2018-03-06 8:28 ` Jarkko Sakkinen
2018-03-06 8:34 ` Winkler, Tomas
2018-03-06 15:39 ` Jason Gunthorpe
2018-03-05 12:56 ` [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Jarkko Sakkinen
2018-03-05 13:09 ` Winkler, Tomas
2018-03-05 17:59 ` Jarkko Sakkinen
2018-03-05 18:04 ` Winkler, Tomas
2018-03-06 8:02 ` Jarkko Sakkinen [this message]
2018-03-06 8:09 ` Winkler, Tomas
2018-03-06 7:49 ` Jarkko Sakkinen
2018-03-06 8:06 ` Winkler, Tomas
2018-03-06 16:32 ` James Bottomley
2018-03-06 16:45 ` Winkler, Tomas
2018-03-06 18:36 ` Mimi Zohar
2018-03-06 21:59 ` Jason Gunthorpe
2018-03-07 15:22 ` Mimi Zohar
2018-03-07 15:41 ` Winkler, Tomas
2018-03-07 15:54 ` Jonathan Corbet
2018-03-07 16:35 ` Mimi Zohar
2018-03-07 18:24 ` Jonathan Corbet
2018-03-10 12:46 ` Jarkko Sakkinen
2018-03-10 12:44 ` Jarkko Sakkinen
2018-03-10 12:37 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306080159.GC3624@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).